Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question #12

Closed
facelessuser opened this issue Aug 3, 2014 · 3 comments
Closed

Question #12

facelessuser opened this issue Aug 3, 2014 · 3 comments

Comments

@facelessuser
Copy link
Contributor

@bizoo this is more of a question than an issue. I was thinking the other day about how SortTabs doesn't really detect the view activation properly when a tab is moved to another group. I had added a complicated workaround that detects these moves properly in a plugin https://github.com/facelessuser/TabsExtra (it uses it for non-sorting purposes).

Well, I thought about back porting the workaround into this plugin (which would require a bit of code, and me figuring out what I originally did and why 😄 ), but I also had a desire to tweak some of the sorting and generally augment it for my own purposes. In the end, I decided to create a manual sorting command built into TabsExtra. But since I didn't design it in a black box, I have clearly borrowed some code from this plugin. I don't see a license, and I wanted to ask you if you were okay with me releasing the sort code with TabsExtra (mentioning you as the original source for sort portion of the code). TabsExtra is under an MIT license.

If you are really interested in the workaround I mentioned, I can take some time and port it into this.

Let me know what you think.

@facelessuser
Copy link
Contributor Author

The commit is here facelessuser/TabsExtra@342a560, though I have not pushed it out to anyone yet. It is different, but also similar. Anyways, I will await your response before moving to distribute it.

@bizoo
Copy link
Owner

bizoo commented Aug 5, 2014

No problem, you can publish your code. Thanks for asking.
Le 4 août 2014 19:11, "Isaac Muse" notifications@github.com a écrit :

The commit is here facelessuser/TabsExtra@342a560
facelessuser/TabsExtra@342a560,
though I have not pushed it out to anyone yet. It is different, but also
similar. Anyways, I will await your response before moving to distribute it.


Reply to this email directly or view it on GitHub
#12 (comment).

@facelessuser
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants