Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Overlapping requests? #4

Closed
jrdioko opened this Issue May 27, 2011 · 6 comments

Comments

Projects
None yet
3 participants
Contributor

jrdioko commented May 27, 2011

This may not be an issue, but how does BSForwardGeocoder handle overlapping requests (i.e. a call to findLocation: before a previous call has finished)? It seems like this could cause inconsistent results because the threads are sharing instance variables.

Owner

bjornsallarp commented May 28, 2011

It doesn't handle overlapping requests, so you are correct, it could return inconsistent results if called multiple times. You will have to prevent searching more than once in your UI. You are free to fork my project and add functionality for handling overlapping requests if you wish. I'll be happy to include it.

Contributor

jrdioko commented May 29, 2011

Alright thanks. If I have some extra time I will.

Contributor

jrdioko commented Jun 10, 2011

I don't think I'll be able to take care of this one (the multi-threading involved is a little over my head), so I'll look at handling it in my UI.

His code doesn't handle it correctly at all. The simple solution is to create a new instance of the ForwardGeocoder for each new lookup you want to do.

Owner

bjornsallarp commented Dec 26, 2011

I disagree with not handling it correctly, it's designed to do one lookup at the time. It mimics MKReveseGeocoder

Contributor

jrdioko commented Dec 27, 2011

I don't think it necessarily needs to, but I think this should be well-documented so people don't misunderstand how it's supposed to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment