Overlapping requests?

[jritzi]

This may not be an issue, but how does BSForwardGeocoder handle overlapping requests (i.e. a call to findLocation: before a previous call has finished)? It seems like this could cause inconsistent results because the threads are sharing instance variables.

[bjornsallarp]

It doesn't handle overlapping requests, so you are correct, it could return inconsistent results if called multiple times. You will have to prevent searching more than once in your UI. You are free to fork my project and add functionality for handling overlapping requests if you wish. I'll be happy to include it.

[jritzi]

Alright thanks. If I have some extra time I will.

[jritzi]

I don't think I'll be able to take care of this one (the multi-threading involved is a little over my head), so I'll look at handling it in my UI.

[HardyMacia]

His code doesn't handle it correctly at all. The simple solution is to create a new instance of the ForwardGeocoder for each new lookup you want to do.

[bjornsallarp]

I disagree with not handling it correctly, it's designed to do one lookup at the time. It mimics MKReveseGeocoder

[jritzi]

I don't think it necessarily needs to, but I think this should be well-documented so people don't misunderstand how it's supposed to be used.