Keybind Improvements #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `IsRebindable` and `IsHidden` fields, along with per-bind callback `OnPress`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fields
Keybind.IsRebindableandKeybind.IsHidden. Binds which are not rebindable still show up in the menu so users can tell what they are, but can't be changed and aren't added to the settings file. Binds which are hidden don't appear in the menu, but are still in the settings file (unless they're also unrebindable). Binds with either flag will continue reviving events as normal.Adds the
Keybind.OnPresscallback. If present, it will be called instead ofmod.GameInputPressed. Has an optional input event argument in the exact same way asmod.GameInputPressed.