Skip to content

Commit 53a1768

Browse files
jkurijkuri
committed
fix(ui): fix style glitches, remove job and build history option from UI
1 parent a8fbc45 commit 53a1768

File tree

4 files changed

+4
-70
lines changed

4 files changed

+4
-70
lines changed

‎src/api/process-manager.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ export function stopBuild(buildId: number): Promise<any> {
453453
const abstruseUrl = `${config.url}/build/${buildId}`;
454454
return setGitHubStatusFailure(gitUrl, abstruseUrl, buildData.repository.access_token);
455455
}
456-
}).catch(err => console.error(err));
456+
}).catch(err => logger.error(err));
457457
}
458458

459459
export function restartJob(jobId: number): Promise<void> {
@@ -490,7 +490,7 @@ export function restartJob(jobId: number): Promise<void> {
490490
} else {
491491
return Promise.resolve();
492492
}
493-
}).catch(err => console.error(err));
493+
}).catch(err => logger.error(err));
494494
}
495495

496496
export function restartJobWithSshAndVnc(jobId: number): Promise<void> {
@@ -568,7 +568,7 @@ export function queueSetupDockerImage(name: string): Observable<any> {
568568
});
569569
}
570570
}, err => {
571-
console.error(err);
571+
logger.error(err);
572572
}, () => {
573573
observer.complete();
574574
});

‎src/app/components/app-build-details/app-build-details.component.html‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -70,39 +70,6 @@ <h2 *ngIf="!build?.data?.pull_request">{{ build?.data?.commits[0]?.message }}</h
7070
<span>{{ totalTime }}</span>
7171
</p>
7272
</div>
73-
74-
<div *ngIf="build.runs && build.runs.length > 1" class="column is-12">
75-
<hr/>
76-
<div class="columns">
77-
<div class="column is-12">
78-
<div class="build-history-btn-container">
79-
<span *ngIf="!showBuildHistory" (click)="showBuildHistory = true" class="build-history-btn">
80-
Show build history
81-
</span>
82-
<span *ngIf="showBuildHistory" (click)="showBuildHistory = false" class="build-history-btn hide">
83-
Hide build history
84-
</span>
85-
</div>
86-
<div *ngIf="showBuildHistory" class="mtop-20">
87-
<div class="columns list-item list-item-mini"
88-
*ngFor="let run of build.runs; let i = index;"
89-
[ngClass]="{ 'is-queued': run.status === 'queued', 'is-success': run.status === 'success', 'is-running': run.status === 'running', 'is-errored': run.status === 'failed' || !run.status }"
90-
>
91-
<div class="column is-4">
92-
<span>{{ run.start_time | date:'dd.MM.yyyy hh:mm:ss' }}</span>
93-
</div>
94-
<div class="column is-4">
95-
<span *ngIf="run.end_time">{{ run.end_time | date:'dd.MM.yyyy hh:mm:ss' }}</span>
96-
</div>
97-
<div class="column is-4">
98-
<span *ngIf="run.status">{{ run.status.charAt(0).toUpperCase() + run.status.slice(1) }}</span>
99-
<span *ngIf="!run.status">Cancelled</span>
100-
</div>
101-
</div>
102-
</div>
103-
</div>
104-
</div>
105-
</div>
10673
</div>
10774
</div>
10875
</div>

‎src/app/components/app-job/app-job.component.html‎

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -89,39 +89,6 @@ <h2 *ngIf="!job?.build?.data?.pull_request">{{ job?.build?.data?.commits[0]?.mes
8989
</div>
9090
</div>
9191

92-
<div *ngIf="job.runs && job.runs.length > 1" class="column is-12">
93-
<hr/>
94-
<div class="columns">
95-
<div class="column is-12">
96-
<div class="build-history-btn-container">
97-
<span *ngIf="!showBuildHistory" (click)="showBuildHistory = true" class="build-history-btn">
98-
Show build history
99-
</span>
100-
<span *ngIf="showBuildHistory" (click)="showBuildHistory = false" class="build-history-btn hide">
101-
Hide build history
102-
</span>
103-
</div>
104-
<div *ngIf="showBuildHistory" class="mtop-20">
105-
<div class="columns list-item list-item-mini"
106-
*ngFor="let run of job.runs; let i = index;"
107-
[ngClass]="{ 'is-queued': run.status === 'queued', 'is-success': run.status === 'success', 'is-running': run.status === 'running', 'is-errored': run.status === 'failed' || !run.status }"
108-
>
109-
<div class="column is-4">
110-
<span>{{ run.start_time | date:'dd.MM.yyyy hh:mm:ss' }}</span>
111-
</div>
112-
<div class="column is-4">
113-
<span *ngIf="run.end_time">{{ run.end_time | date:'dd.MM.yyyy hh:mm:ss' }}</span>
114-
</div>
115-
<div class="column is-4">
116-
<span *ngIf="run?.status">{{ run.status.charAt(0).toUpperCase() + run.status.slice(1) }}</span>
117-
<span *ngIf="!run.status">Cancelled</span>
118-
</div>
119-
</div>
120-
</div>
121-
</div>
122-
</div>
123-
</div>
124-
12592
</div>
12693
</div>
12794
</div>

‎src/app/components/app-terminal/app-terminal.component.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="window-terminal-container batman-ansi-theme">
1+
<div class="window-terminal-container material-dark-ansi-theme">
22
<div class="terminal" *ngFor="let cmd of commands; let i = index;" [id]="i">
33
<div class="command-line" (click)="toogleCommand(i)">
44
<span class="icon">

0 commit comments

Comments
 (0)