feat(ledger): Deposit should be collected when pool is retired and re-registered #640 #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arepala-uml
commented
Sep 1, 2025
arepala-uml
commented
- Added PoolState interface type in ledger/common/state.go where it helps for querying the current pool state.
- Modified all the rules.go files of all eras for replacing PoolRegistration() to PoolCurrentState.
- Remove PoolRegistration() function from CertState.
- Tested by pointing dingo to a local gouroboros, disabled check for TX validation threshold & ran dingo to sync "preview" network. I did not observe any errors no “value not conserved” failures with a 500A (500,000,000 lovelace) delta.
…oolRegistration Signed-off-by: Akhil Repala <arepala@blinklabs.io>
wolf31o2
requested changes
Sep 1, 2025
Signed-off-by: Akhil Repala <arepala@blinklabs.io>
Signed-off-by: Akhil <145306795+arepala-uml@users.noreply.github.com>
Signed-off-by: Akhil Repala <arepala@blinklabs.io>
wolf31o2
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.