Skip to content

feat(ledger): Deposit should be collected when pool is retired and re-registered #640 #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 3, 2025
Merged

feat(ledger): Deposit should be collected when pool is retired and re-registered #640 #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28fa5b2
feat(ledger): Used current PoolState for deposit checks and dropped P…
arepala-uml Sep 1, 2025
76f5985
feat(ledger): Added clear definition of PoolCurrentState in PoolState
arepala-uml Sep 3, 2025
75f41ab
Merge branch 'main' into deposit_register
arepala-uml Sep 3, 2025
5ba36b1
feat(ledger): Correctly formatted the ledger/common/state.go file
arepala-uml Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions internal/test/ledger/ledger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,20 +63,17 @@ func (ls MockLedgerState) StakeRegistration(
return ret, nil
}

func (ls MockLedgerState) PoolRegistration(
func (ls MockLedgerState) PoolCurrentState(
poolKeyHash []byte,
) ([]common.PoolRegistrationCertificate, error) {
ret := []common.PoolRegistrationCertificate{}
) (*common.PoolRegistrationCertificate, *uint64, error) {
for _, cert := range ls.MockPoolRegistration {
if string(
common.Blake2b224(cert.Operator).Bytes(),
) == string(
poolKeyHash,
) {
ret = append(ret, cert)
if string(common.Blake2b224(cert.Operator).Bytes()) == string(poolKeyHash) {
// pretend latest registration is current; no retirement support in mock
c := cert
return &c, nil, nil
}
}
return ret, nil
return nil, nil, nil
}

func (ls MockLedgerState) SlotToTime(slot uint64) (time.Time, error) {
Expand Down
4 changes: 2 additions & 2 deletions ledger/alonzo/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,11 +289,11 @@ func UtxoValidateValueNotConservedUtxo(
for _, cert := range tx.Certificates() {
switch tmpCert := cert.(type) {
case *common.PoolRegistrationCertificate:
certs, err := ls.PoolRegistration(common.Blake2b224(tmpCert.Operator).Bytes())
reg, _, err := ls.PoolCurrentState(common.Blake2b224(tmpCert.Operator).Bytes())
if err != nil {
return err
}
if len(certs) == 0 {
if reg == nil {
producedValue += uint64(tmpPparams.PoolDeposit)
}
case *common.StakeRegistrationCertificate:
Expand Down
4 changes: 2 additions & 2 deletions ledger/babbage/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,11 +275,11 @@ func UtxoValidateValueNotConservedUtxo(
for _, cert := range tx.Certificates() {
switch tmpCert := cert.(type) {
case *common.PoolRegistrationCertificate:
certs, err := ls.PoolRegistration(common.Blake2b224(tmpCert.Operator).Bytes())
reg, _, err := ls.PoolCurrentState(common.Blake2b224(tmpCert.Operator).Bytes())
if err != nil {
return err
}
if len(certs) == 0 {
if reg == nil {
producedValue += uint64(tmpPparams.PoolDeposit)
}
case *common.StakeRegistrationCertificate:
Expand Down
10 changes: 9 additions & 1 deletion ledger/common/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,22 @@ type UtxoState interface {
// CertState defines the interface for querying the certificate state
type CertState interface {
StakeRegistration([]byte) ([]StakeRegistrationCertificate, error)
PoolRegistration([]byte) ([]PoolRegistrationCertificate, error)
}

// PoolState defines the interface for querying the current pool state
type PoolState interface {
// PoolCurrentState returns the latest active registration certificate for the given pool key hash.
// It also returns the epoch of a pending retirement certificate, if one exists.
// If the pool is not registered, the registration certificate will be nil.
PoolCurrentState([]byte) (*PoolRegistrationCertificate, *uint64, error)
}

// LedgerState defines the interface for querying the ledger
type LedgerState interface {
UtxoState
CertState
SlotState
PoolState
NetworkId() uint
}

Expand Down
4 changes: 2 additions & 2 deletions ledger/conway/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,11 @@ func UtxoValidateValueNotConservedUtxo(
for _, cert := range tx.Certificates() {
switch tmpCert := cert.(type) {
case *common.PoolRegistrationCertificate:
certs, err := ls.PoolRegistration(common.Blake2b224(tmpCert.Operator).Bytes())
reg, _, err := ls.PoolCurrentState(common.Blake2b224(tmpCert.Operator).Bytes())
if err != nil {
return err
}
if len(certs) == 0 {
if reg == nil {
producedValue += uint64(tmpPparams.PoolDeposit)
}
case *common.RegistrationCertificate:
Expand Down
4 changes: 2 additions & 2 deletions ledger/shelley/rules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,11 +196,11 @@ func UtxoValidateValueNotConservedUtxo(
for _, cert := range tx.Certificates() {
switch tmpCert := cert.(type) {
case *common.PoolRegistrationCertificate:
certs, err := ls.PoolRegistration(common.Blake2b224(tmpCert.Operator).Bytes())
reg, _, err := ls.PoolCurrentState(common.Blake2b224(tmpCert.Operator).Bytes())
if err != nil {
return err
}
if len(certs) == 0 {
if reg == nil {
producedValue += uint64(tmpPparams.PoolDeposit)
}
case *common.StakeRegistrationCertificate:
Expand Down
Loading