-
-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook up onError function for rpc server and next #3460
Conversation
🦋 Changeset detectedLatest commit: a15c99a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you a lot for adding this!
I also started wondering if we don't want to have it on the RPC plugin settings instead — e.g. someone may not use RPC at all, and then it's not clear what |
Hmm but we have 2 onErrors, one for BlitzServer and one for RPCHandler? The only thing actually missing is that BlitzServer one is only used in API routes not in SSR/SSG and that might me useful? |
Update on the last comment, I added error handling into GSSP / GSP / API functions |
Ok, after further thought, I think it's good. Thanks again for working on that — it's super helpful !! |
Closes: #3422, #3200
What are the changes and their implications?
onError
for next server initonError
fromrpcHandler