-
-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blitz recipe-install support for NextJS App Router projects #4287
base: main
Are you sure you want to change the base?
Conversation
…with NextJS's App Router filesystem.
🦋 Changeset detectedLatest commit: 0289d65 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think the logical next step would be adding better error handling to prevent it from hanging during a recipe install. Having it create non-existent folders is one idea I've had. Looking over it, the issue happens at the .addTransformFilesStep part of the recipe, at least for the tailwind recipe. Working on a way to implement better error handling in the transform.ts file so it doesn't hang. |
yeah @Doc0x1 that's a good idea. Let me know when the PR is ready for a review! |
…s#4290) * Added support for legacy projects that have the pages folder located inside a /src directory * Fixed line 687 for path.resolve(`${findPagesDirectory}/api/rpc`) not actually calling the function and added path.resolve's to findPagesDirectory * Update for lines 56 and 1340 to add support for app and pages directories located in /src
Will do. I just got some good web dev work so its gonna be maybe a couple weeks before im able to get back to actively working on this, so just a heads up. Glad i could help with getting that other PR done though |
content: [ | ||
"./{src/pages,src/components,src/app,src,pages,components,app}/**/*.{js,ts,jsx,tsx,mdx}", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰 https://nextjs.org/docs/app/building-your-application/styling/tailwind-css#configuring-tailwind
content: [ | |
"./{src/pages,src/components,src/app,src,pages,components,app}/**/*.{js,ts,jsx,tsx,mdx}", | |
], | |
content: [ | |
'./app/**/*.{js,ts,jsx,tsx,mdx}', | |
'./pages/**/*.{js,ts,jsx,tsx,mdx}', | |
'./components/**/*.{js,ts,jsx,tsx,mdx}', | |
'./src/**/*.{js,ts,jsx,tsx,mdx}', | |
], |
* perf: add check to make sure only non expired sessions are selected by default * remove console.logs * Create chatty-ants-bake.md * remove `expiresAt` from the publicData * remove internal from changelog --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat: export `BlitzServerMiddleware` from blitz-next * Create sixty-pants-hunt.md --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* add ajv to devDeps * Create four-dots-retire.md
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… Nextjs 13 or higher (blitz-js#4299) * fix: remove custom errors thrown by blitz * Create curvy-cougars-lick.md * use require and eval rather than the await which becomes a `yield import` possibly causing the issue * pnpm lock fix * Update .changeset/curvy-cougars-lick.md * add comment * use correct error type * Apply suggestions from code review
…#4300) * feat: remove restriction to use secure cookies in localhost * changeset * pnpm lock fix * Update .changeset/grumpy-deers-rest.md * Update .changeset/grumpy-deers-rest.md --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* Version Packages * pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
* fix: process.kill("SIGABRT") not supported on windows * fix: use process.kill("SIGINT") across all operative systems * Update .changeset/clever-insects-shave.md --------- Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
* fix: production issue * Update .changeset/soft-tables-ring.md --------- Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
* Version Packages * chore: update pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
…blitz-js#4318) * fix stray DYNAMIC_SERVER_USAGE thrown * cleanup * chore: changeset
* Use this.rootContext instead of webpack internals Ensures the root context is read from the public API that webpack exposes. This is the first step for Turbopack support as Turbopack includes `this.rootContext` as well * Turbopack support for Blitz * Update packages/blitz-rpc/src/server/loader/server/loader-server.ts Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> * fix: CI and update next.js version in test app * feat: add tests for turbo and expose new `turbo` boolean * upgrade to latest next version * use latest canary in internal packages and tests * chore: add changeset * chore: minor fix on how the test is run * fix stray DYNAMIC_SERVER_USAGE thrown * cleanup * chore: changeset * pnpm lock fix * fix turbo tests * fixes * oops * add turbo config only when needed * remove need for any change to `next.config.js` --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
* Version Packages * pnpm lock fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
* fix: add missing host in next-auth adapter * Create red-masks-drop.md * Update .changeset/red-masks-drop.md
* do not oveeride existing config * Create calm-deers-sin.md * Update packages/blitz-next/src/index-server.ts
* Version Packages * update pnpm lock --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
up |
* move it back to index-server * fix turbopack * Create big-cars-raise.md * cleanup * fix * fix lint
* Version Packages * pnpm lock fix --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddharth Suresh <siddh.suresh@gmail.com>
* upgrade to latest v4 * Create warm-scissors-juggle.md * Update .changeset/warm-scissors-juggle.md * also check for flightcontrol platform
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
I do not know what is the state, but I tried blitz and I have just issues, this is one of them... |
I am still having this issue as of for version 2.0.10 is it safe to use the recipe even if it errors out? Thanks, |
…with NextJS's App Router filesystem.
Might need to close this one, was working on updating it for the current upstream main branch of Blitz and not sure if I did so correctly. |
What are the changes and their implications?
Bringing the Blitz recipe-install feature up to speed with the newer NextJS App Router projects.
TODO:
Closes: #4189
Feature Checklist
Just a heads up, this is my first time contributing to a community project on GitHub, and so there's been a lot of new things I've been picking up in a pretty short amount of time. I've done my best to follow the contributing guidelines and if I've made any mistakes, feel free to let me know so I can avoid them in the future.
Anyway, this pull request is by no means ready for a merge, but I wanted to open it so I could get some feedback from those of you that might be more familiar with the recipe system than I currently am.