Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode ESLint integration not working #492

Closed
wKovacs64 opened this issue Apr 30, 2020 · 0 comments · Fixed by blitz-js/blitz#373
Closed

VSCode ESLint integration not working #492

wKovacs64 opened this issue Apr 30, 2020 · 0 comments · Fixed by blitz-js/blitz#373

Comments

@wKovacs64
Copy link
Contributor

What is the problem?

The introduction of .eslintrc in blitz-js/blitz#298 broke VSCode/ESLint integration (reproduced on multiple devices).

Steps to Reproduce:

Assuming you had ESLint working in VSCode previously...

  1. Clone Blitz repo (current canary branch as of this issue being logged)
  2. Install dependencies (yarn)
  3. Open in VSCode
  4. Open a file (e.g. packages/core/src/index.ts) and observe lint errors (e.g. Parsing error: The keyword 'export' is reserved)
  5. Delete .eslintrc and the errors go away and integration is restored

Versions:

N/A

Supporting Documentation

The tsdx CLI supports merging .eslintrc.js (don't think it honors .eslintrc though), but that isn't enough for VSCode, which doesn't know to perform said merge (so it only looks at the config it finds, which in this case is missing things like the TS parser, etc.). The solution from tsdx is to "eject" the ESLint config if you need to extend it while retaining editor integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants