Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First use of latest .prefpane 21-09-30 installs Chromium in wrong partition #33

Closed
pook52mb opened this issue Oct 10, 2021 · 1 comment
Closed

First use of latest .prefpane 21-09-30 installs Chromium in wrong partition #33

pook52mb opened this issue Oct 10, 2021 · 1 comment

Comments

@pook52mb
Copy link

I have my iMac hdd partitioned in quarters for 10.6, 10.9, 10.11 (unused), and 10.13 (also unused). When I clicked to open the .prefpane in the .dmg, it asked me about the widevine install, and downloaded and installed Chromium with a Chrome Icon in the 10.6 partition. I was able to move it over to the Applications folder in the 10.9 partition, and it seems to work ok from there. But it overwrote my copy of FreeSMUG Chromium 49 that was in the 10.6 partition. So that required me to reboot into 10.6 and reinstall the older version after cleaning up with Find Any File. Please add some checking in the app so that it either installs Chromium in the same partition as the .prefpane, or simply asks one to choose which partition to install Chromium.
@blueboxd
Copy link
Owner

Sorry, I'm not the author of the downloader and the downloader is not part of this project.
So, please report issues on the discussion.

blueboxd pushed a commit that referenced this issue Oct 16, 2021
Revert "Enable PageInfoV2Desktop by default"
30f6e0b 
This reverts commit 842626c.

Reason for revert: [sheriff] suspected to cause multiple failures in 
SafetyTipPageInfoBubbleViewBrowserTests on linux-ubsan-vptr:

https://ci.chromium.org/p/chromium/builders/ci/linux-ubsan-vptr/6970

Sample failure:
[ RUN      ] All/SafetyTipPageInfoBubbleViewBrowserTest.BubbleWaitsForVisible/1
[...]
../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23: runtime error: downcast of address 0x180601885e00 which does not point to an object of type 'PageInfoBubbleView'
0x180601885e00: note: object is of type 'PageInfoNewBubbleView'
 00 00 00 00  18 70 11 10 50 56 00 00  80 68 50 01 06 18 00 00  b8 00 00 00 30 00 00 00  00 00 00 00
              ^~~~~~~~~~~~~~~~~~~~~~~
              vptr for 'PageInfoNewBubbleView'
    #0 0x564ffa77d440 in SafetyTipPageInfoBubbleViewBrowserTest::CheckPageInfoShowsSafetyTipInfo(Browser*, security_state::SafetyTipStatus, GURL const&) chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23
    #1 0x564ffa788397 in SafetyTipPageInfoBubbleViewBrowserTest_BubbleWaitsForVisible_Test::RunTestOnMainThread() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:837:3
    #2 0x565002ae1026 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:868:7
    #3 0x565001aae15a in Run base/callback.h:142:12
    #4 0x565001aae15a in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1745:38
    #5 0x565001aaba50 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1083:18
    #6 0x564ffd8e2f00 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:957:28
    #7 0x564ffe307f82 in Run base/callback.h:142:12
    #8 0x564ffe307f82 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:41:29
    #9 0x564ffd8e2368 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:865:25
    #10 0x564ffd8e889c in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner_impl.cc:131:15
    #11 0x564ffd8dec1e in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:45:32
    #12 0x564fff2a06e8 in content::RunBrowserProcessMain(content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner_impl.cc:641:10
    #13 0x564fff2a2e90 in content::ContentMainRunnerImpl::RunBrowser(content::MainFunctionParams&, bool) content/app/content_main_runner_impl.cc:1137:10
    #14 0x564fff2a1f18 in content::ContentMainRunnerImpl::Run(bool) content_main_runner_impl.cc
    #15 0x564fff29dde0 in content::RunContentProcess(content::ContentMainParams const&, content::ContentMainRunner*) content_main.cc
    #16 0x564fff29e7dd in content::ContentMain(content::ContentMainParams const&) content_main.cc
    #17 0x565002adfcff in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:712:3
    #18 0x5650018271c4 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:401:20
    #19 0x564ffa79d759 in SafetyTipPageInfoBubbleViewBrowserTest::SetUp() chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:306:27
    #20 0x564ffb8f8c7d in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc:2701:3
    #21 0x564ffb8fa600 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2885:11
    #22 0x564ffb8fc1bb in testing::TestSuite::Run() third_party/googletest/src/googletest/src/gtest.cc:3044:30
    #23 0x564ffb9115ca in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5903:44
    #24 0x564ffb90fd8c in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc:5470:10
    #25 0x565001a12e28 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2492:46
    #26 0x565001a12e28 in base::TestSuite::Run() base/test/test_suite.cc:445:16
    #27 0x5650017d0bac in ChromeTestSuiteRunner::RunTestSuiteInternal(ChromeTestSuite*) chrome/test/base/chrome_test_launcher.cc:88:22
    #28 0x5650017d0c1b in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome_test_launcher.cc
    #29 0x565002b8529b in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:409:31
    #30 0x5650017d11b1 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:284:10
    #31 0x5650017c9dcc in main chrome/test/base/browser_tests_main.cc:61:10
    #32 0x7fc242b01bf6 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21bf6)
    #33 0x564ff76da7e9 in _start (/b/s/w/ir/out/Release/browser_tests+0xe8af7e9)

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../../chrome/browser/ui/views/page_info/safety_tip_page_info_bubble_view_browsertest.cc:390:23 in 

Original change's description:
> Enable PageInfoV2Desktop by default
>
> Enable flag and remove testing config.
>
> Bug: 1188101
> Change-Id: Ifd839436f3d4c0127d15b449bbca84855ccd858f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3217207
> Reviewed-by: Balazs Engedy <engedy@chromium.org>
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Reviewed-by: Theodore Olsauskas-Warren <sauski@google.com>
> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
> Cr-Commit-Position: refs/heads/main@{#931972}

Bug: 1188101
Change-Id: Ic51b9fdc730b7046e24b4d394248218b86eef09d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226638
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Owners-Override: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/main@{#932067}
blueboxd pushed a commit that referenced this issue Nov 26, 2021
Disable flaky Cart tests on Chromeos.
b836cb2 
(cherry picked from commit 3ae4235)

Bug: 1257964
Change-Id: Iebd00b1cbdb3c5adcc0abd29281822917b0e803a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3216065
Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Owners-Override: Nic Hollingum <hollingum@google.com>
Auto-Submit: Nic Hollingum <hollingum@google.com>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#930017}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218147
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/branch-heads/4664@{#33}
Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
blueboxd pushed a commit that referenced this issue Jan 15, 2022
Revert "Remote powerwash on Chromad via policy"
de57069 
This reverts commit 6ff1599.

Reason for revert: Seems to have caused browser_test failures on linux-chromeos-chrome 

https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/19698
rowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x563ae696f899 base::debug::CollectStackTrace()
#1 0x563ae68d6683 base::debug::StackTrace::StackTrace()
#2 0x563ae6ff8293 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f9ac9026040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f)
#4 0x563ae7720266 PrefChangeRegistrar::RemoveAll()
#5 0x563ae7720222 PrefChangeRegistrar::~PrefChangeRegistrar()
#6 0x563ae2f37095 std::__1::unique_ptr<>::reset()
#7 0x563ae3696a1b policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager()
#8 0x563ae3696a38 policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager()
#9 0x563ae369a699 policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh()
#10 0x563ae369a6fe policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh()
#11 0x563ae6a0edbd BrowserProcessImpl::~BrowserProcessImpl()
#12 0x563ae6a0edea BrowserProcessImpl::~BrowserProcessImpl()
#13 0x563ae6a668e9 browser_shutdown::ShutdownPostThreadsStop()
#14 0x563ae6a0e226 ChromeBrowserMainParts::PostDestroyThreads()
#15 0x563ae349ef9b ash::ChromeBrowserMainPartsAsh::PostDestroyThreads()
#16 0x563ae495d2d9 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#17 0x563ae495e53c content::BrowserMainRunnerImpl::Shutdown()
#18 0x563ae495a9ce content::BrowserMain()
#19 0x563ae555e819 content::RunBrowserProcessMain()
#20 0x563ae555f8e0 content::ContentMainRunnerImpl::RunBrowser()
#21 0x563ae555f431 content::ContentMainRunnerImpl::Run()
#22 0x563ae555d209 content::RunContentProcess()
#23 0x563ae555d861 content::ContentMain()
#24 0x563ae6ff6f2b content::BrowserTestBase::SetUp()
#25 0x563ae68bf947 InProcessBrowserTest::SetUp()
#26 0x563ae3b0fbed testing::Test::Run()
#27 0x563ae3b10520 testing::TestInfo::Run()
#28 0x563ae3b10ce1 testing::TestSuite::Run()
#29 0x563ae3b1a61a testing::internal::UnitTestImpl::RunAllTests()
#30 0x563ae3b1a219 testing::UnitTest::Run()
#31 0x563ae69d5af8 base::TestSuite::Run()
#32 0x563ae688bfa1 BrowserTestSuiteRunnerChromeOS::RunTestSuite()
#33 0x563ae70407b7 content::LaunchTests()
#34 0x563ae688e77a LaunchChromeTests()
#35 0x563ae688bf23 main
chromium#36 0x7f9ac9008bf7 __libc_start_main
#37 0x563ae134462a _start

Original change's description:
> Remote powerwash on Chromad via policy
>
> Implement remote powerwash on Chromad, using the recently added
> ChromadToCloudMigrationEnabled policy. The powerwash will be used to
> start the migration of AD managed devices into cloud management. Besides
> having the new policy enabled, the device needs to be on the login
> screen and the enrollment ID must have already been uploaded to
> DMServer.
>
> Bug: 1209246
> Change-Id: I6a67b8a8a43c28bc5f03f27e96d0415f69b6bc83
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141873
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Commit-Queue: Felipe Andrade <fsandrade@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#959123}

Bug: 1209246
Change-Id: If067abcf2a9289ebacaeb240b1f67749c305509c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3389555
Auto-Submit: Scott Violet <sky@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#959243}
blueboxd pushed a commit that referenced this issue Feb 3, 2022
@mohamedamir
[Autofill] Report Autofill PopupHidingReason in histograms
3c6266d 
This CL instroduces metrics reporting for PopupHidingReason.
The metric captures the reasons for which the Autofill popup gets
hidden. The metric is reported right before hiding the popup.

(cherry picked from commit 0721d01)

Bug: 1278712
Change-Id: I1943dabc433e241ebe29af43b0aaec14539b1270
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329784
Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Matthias Körber <koerber@google.com>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#950795}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329849
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4758@{#33}
Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
blueboxd pushed a commit that referenced this issue Jun 22, 2022
@recvfrom
Add metrics for Blob URL usage in data URL workers
f3701f4 
Note that I didn't see an easy way to add tests for this,
but I verified that the histograms were updated after running
the following WPT that creates a Blob URL from a data URL
worker:

html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/blob-data.https.html

(cherry picked from commit 2d7cca1)

Bug: 1058759,1325852
Change-Id: I9644d69fb143b89ff6cd512a3758aba5b15e3b27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3639563
Commit-Queue: Andrew Williams <awillia@google.com>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1002966}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649946
Cr-Commit-Position: refs/branch-heads/5060@{#33}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd pushed a commit that referenced this issue Aug 31, 2022
[Sync] Fix sync node browser view on sync-internals
0e6f3d6 
This Cl fixes node details view for huge sync entity items which don't fit into screen.

(cherry picked from commit 23e427e)

Bug: 1346541
Change-Id: I8df49d5af4ec6545a33d8e260d431d6239fef99f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3782805
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1027727}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3780933
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/branch-heads/5195@{#33}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd pushed a commit that referenced this issue Sep 29, 2022
@vikaschromie
Revert "[Dr-Dc] Disable DrDc on some gpus ."
2d2356e 
This reverts commit c4a306d.

Reason for revert: crbug.com/1354945

Original change's description:
> [Dr-Dc] Disable DrDc on some gpus .
>
> Disable DrDc on some gpus via gpudriverbugworkaround.
>
> (cherry picked from commit 1e72014)
>
> Bug: 1354201
> Change-Id: Ia54ea2ae67bdd93d5085e81eca32b33433073eec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3840470
> Commit-Queue: vikas soni <vikassoni@chromium.org>
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Cr-Original-Commit-Position: refs/heads/main@{#1036894}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3842868
> Reviewed-by: Krishna Govind <govind@chromium.org>
> Owners-Override: Krishna Govind <govind@chromium.org>
> Reviewed-by: vikas soni <vikassoni@chromium.org>
> Cr-Commit-Position: refs/branch-heads/5249@{#5}
> Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}

Bug: 1354201
Change-Id: I849932e2bf1766f849d52c25c426c923dedf296e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3845891
Reviewed-by: Krishna Govind <govind@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Krishna Govind <govind@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{#33}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
@philloooo
DPWA: enable detailed install dialog
3b32e46 
The reature was disabled to push release timeline from 107 to 108.
Need to re-enable on M108.

(cherry picked from commit 53bf814)

Bug: 1374870
Change-Id: I6073706a24ebc179a645f2ed7a2a284e665dedbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3957315
Auto-Submit: Phillis Tang <phillis@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Commit-Queue: Phillis Tang <phillis@chromium.org>
Commit-Queue: Glenn Hartmann <hartmanng@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1059417}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3960534
Cr-Commit-Position: refs/branch-heads/5359@{#33}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
@xchrdw
Safety check: Check for null RuleIterator
8c2d5e3 
The iterator can be null if the pref has no entries.

(cherry picked from commit 79d96c4)

Bug: 1401386
Change-Id: Ic25b9f4735dc184a4a0ed7a794244446a676bca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4116579
Reviewed-by: Side YILMAZ <sideyilmaz@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1085399}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4118535
Cr-Commit-Position: refs/branch-heads/5481@{#33}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
@arichiv
{M111 PICK} [StorageKey] Fix fizzer
48e133c 
This fixes a compile issue and one error that will occur when
it starts to run. We need to be strict on DeserializeForLocalStorage as
we are in Deserialize. We should require the exact format that
SerializeForLocalStorage outputs and no others.

(cherry picked from commit e220d62)

Bug: 1410859, 1407243
Change-Id: I51e57c192af60873e8e074e5f1eb07d23b4943d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4200732
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Ari Chivukula <arichiv@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1098227}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4205607
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{#33}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
[Merge-112][Passwords] Additional metric for OTP regexes
c326a04 
The metric measures how often an OTP regexs detects anything. It will be
used to compare coverage between new and old regexes.

(cherry picked from commit 51d4c63)

Bug: 1382805
Change-Id: I86a3474754d7a5bc22a79205a60d8d7d5d3710f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4290992
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1109635}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4293107
Cr-Commit-Position: refs/branch-heads/5615@{#33}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
@Dp-Goog
[dPWA] Fix BrowserContext raw_ptr crash in ManifestUpdateManager
c8096ba 
This CL fixes a crash in ManifestUpdateManager when the profile or
browser context no longer exists while waiting for app windows
to close.

(cherry picked from commit f7508a9)

Bug: 1427218
Change-Id: I3a915d4847a8d97fcc77dd620713ad18d7b12808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370365
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1121877}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370978
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/branch-heads/5672@{#33}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
@linnan-github
Add source registration time config to AttributionCommonAggregatableM…
b6d93c9 
…etadata proto

This field will be needed to indicate whether to include source
registration time in the aggregatable reports and null reports.
In this CL this field is always set to INCLUDE and the actual use of
this field will be in a follow up CL.

The database version is bumped to ensure that this field is always set
in the new version.

(cherry picked from commit cecd731)

Bug: 1440161
Change-Id: If4939b23b15a42a2a5bdeeba2131e0b5294f81e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4480169
Commit-Queue: Nan Lin <linnan@chromium.org>
Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1135910}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4479982
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5735@{#33}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pook52mb @blueboxd