Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error in toolchain/apple/toolchain.gni #35

Closed
erkserkserks opened this issue Nov 1, 2021 · 3 comments
Closed

Build error in toolchain/apple/toolchain.gni #35

erkserkserks opened this issue Nov 1, 2021 · 3 comments

Comments

@erkserkserks
Copy link

Hello, I'm trying to build according to the wiki page
, however I encounter the following build error:

ninja -C ../out/release chrome
ninja: Entering directory `../out/release'
[0/1] Regenerating ninja files
ERROR at //build/toolchain/apple/toolchain.gni:363:91: Undefined identifier in string expansion.
      command = "rm -f {{output}} && TOOL_VERSION=${tool_versions.filter_libtool} python $script $libtool -static {{arflags}} -o {{output}} -filelist $rspfile"
                                                                                          ^-----
"script" is not currently in scope.
See //build/toolchain/mac/BUILD.gn:14:3: whence it was called.
  apple_toolchain(target_name) {
  ^-----------------------------
See //build/toolchain/mac/BUILD.gn:40:1: whence it was called.
mac_toolchain("clang_arm") {
^---------------------------
See //BUILD.gn:75:1: which caused the file to be included.
group("gn_all") {
^----------------
FAILED: build.ninja
../../src/buildtools/mac/gn --root=../../src -q --regeneration gen .
ninja: error: rebuilding 'build.ninja': subcommand failed

It looks like the $script variable never gets initialized here because toolchain_uses_lld is true and the second branch is taken.

I'm building on a macOs 11.6 VM.
@erkserkserks
Copy link
Author

I tried today on a fresh macOS 12 VM with just Xcode and macports installed, and still no luck. I've attached the build output.

build_log.txt

@blueboxd
Copy link
Owner

Hi, thank you for the reporting and sorry for late reply.

It looks like the $script variable never gets initialized here because toolchain_uses_lld is true and the second branch is taken.

Oh, I didn't notice that because I don't use lld.
Moved initialization of $script to the parent scope, so it'll be fixed in the next push.
But this project is not intended to be built with lld, and maybe lld does not support old OSes...

@erkserkserks
Copy link
Author

No worries - thanks for keeping Chromium alive on these old macs!

It does appear that using lld results in a bunch of build errors. I added use_lld = false to the chromium-legacy/out/release/args.gn file and was able to build successfully with ld64.

blueboxd pushed a commit that referenced this issue Nov 26, 2021
Reduce a11y noise in holding space.
cff2671 
When a11y description is not explicitly specified, tooltip text will be
used. If a11y description does not match a11y name, it'll be announced.
In the case of in-progress downloads, the a11y name != the a11y
description, but the tooltip text is noisy and redundant since the same
download progress information is communicated via browser announcements.

This CL explicitly sets the a11y description to empty so that only the
a11y name will be announced.

(cherry picked from commit 1074593)

Bug: 1258939
Change-Id: I295fa3c1f7bb0a75c921eea0abeb33d48150cca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218112
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#930356}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3218404
Auto-Submit: David Black <dmblack@google.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4664@{#35}
Cr-Branched-From: 24dc4ee-refs/heads/main@{#929512}
blueboxd pushed a commit that referenced this issue Jan 15, 2022
Revert "Remote powerwash on Chromad via policy"
de57069 
This reverts commit 6ff1599.

Reason for revert: Seems to have caused browser_test failures on linux-chromeos-chrome 

https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/19698
rowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x563ae696f899 base::debug::CollectStackTrace()
#1 0x563ae68d6683 base::debug::StackTrace::StackTrace()
#2 0x563ae6ff8293 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#3 0x7f9ac9026040 (/lib/x86_64-linux-gnu/libc-2.27.so+0x3f03f)
#4 0x563ae7720266 PrefChangeRegistrar::RemoveAll()
#5 0x563ae7720222 PrefChangeRegistrar::~PrefChangeRegistrar()
#6 0x563ae2f37095 std::__1::unique_ptr<>::reset()
#7 0x563ae3696a1b policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager()
#8 0x563ae3696a38 policy::ActiveDirectoryMigrationManager::~ActiveDirectoryMigrationManager()
#9 0x563ae369a699 policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh()
#10 0x563ae369a6fe policy::BrowserPolicyConnectorAsh::~BrowserPolicyConnectorAsh()
#11 0x563ae6a0edbd BrowserProcessImpl::~BrowserProcessImpl()
#12 0x563ae6a0edea BrowserProcessImpl::~BrowserProcessImpl()
#13 0x563ae6a668e9 browser_shutdown::ShutdownPostThreadsStop()
#14 0x563ae6a0e226 ChromeBrowserMainParts::PostDestroyThreads()
#15 0x563ae349ef9b ash::ChromeBrowserMainPartsAsh::PostDestroyThreads()
#16 0x563ae495d2d9 content::BrowserMainLoop::ShutdownThreadsAndCleanUp()
#17 0x563ae495e53c content::BrowserMainRunnerImpl::Shutdown()
#18 0x563ae495a9ce content::BrowserMain()
#19 0x563ae555e819 content::RunBrowserProcessMain()
#20 0x563ae555f8e0 content::ContentMainRunnerImpl::RunBrowser()
#21 0x563ae555f431 content::ContentMainRunnerImpl::Run()
#22 0x563ae555d209 content::RunContentProcess()
#23 0x563ae555d861 content::ContentMain()
#24 0x563ae6ff6f2b content::BrowserTestBase::SetUp()
#25 0x563ae68bf947 InProcessBrowserTest::SetUp()
#26 0x563ae3b0fbed testing::Test::Run()
#27 0x563ae3b10520 testing::TestInfo::Run()
#28 0x563ae3b10ce1 testing::TestSuite::Run()
#29 0x563ae3b1a61a testing::internal::UnitTestImpl::RunAllTests()
#30 0x563ae3b1a219 testing::UnitTest::Run()
#31 0x563ae69d5af8 base::TestSuite::Run()
#32 0x563ae688bfa1 BrowserTestSuiteRunnerChromeOS::RunTestSuite()
#33 0x563ae70407b7 content::LaunchTests()
#34 0x563ae688e77a LaunchChromeTests()
#35 0x563ae688bf23 main
chromium#36 0x7f9ac9008bf7 __libc_start_main
#37 0x563ae134462a _start

Original change's description:
> Remote powerwash on Chromad via policy
>
> Implement remote powerwash on Chromad, using the recently added
> ChromadToCloudMigrationEnabled policy. The powerwash will be used to
> start the migration of AD managed devices into cloud management. Besides
> having the new policy enabled, the device needs to be on the login
> screen and the enrollment ID must have already been uploaded to
> DMServer.
>
> Bug: 1209246
> Change-Id: I6a67b8a8a43c28bc5f03f27e96d0415f69b6bc83
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141873
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Commit-Queue: Felipe Andrade <fsandrade@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#959123}

Bug: 1209246
Change-Id: If067abcf2a9289ebacaeb240b1f67749c305509c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3389555
Auto-Submit: Scott Violet <sky@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#959243}
blueboxd pushed a commit that referenced this issue Feb 3, 2022
Updating XTBs based on .GRDs from branch 4758
a5ced48 
Change-Id: Ia1d1f183cb7a4f1aa1512f9b885c189c2940bdbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338971
Auto-Submit: Ben Mason <benmason@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4758@{#35}
Cr-Branched-From: 4a2cf4b-refs/heads/main@{#950365}
blueboxd pushed a commit that referenced this issue Jun 22, 2022
[Merge to M103] saved_desks: Update desk bar button text
5532573 
In the desk bar, the button to show all saved templates and desks should
be updated based on the string doc. Button text should be as follows.
  1. `Saved for later`: When Desk Templates is off
  2. `Library`: When Desk Templates is on

(cherry picked from commit 6fab7b9)

Bug: 1324300
Change-Id: I6f7bef48164c8533a75615c341863529ae1fada5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3639705
Reviewed-by: Min Chen <minch@chromium.org>
Commit-Queue: Yongshun Liu <yongshun@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003430}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3651051
Cr-Commit-Position: refs/branch-heads/5060@{#35}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd pushed a commit that referenced this issue Aug 31, 2022
@GrapeGreen
[Merge 105] CrosapiAsh: Fix ODR violation on std::unique_ptr<Printing…
a793e91 
…MetricsAsh>

The ODR violation happened due to std::unique_ptr<PrintingMetricsAsh>
being conditionally defined based on the USE_CUPS flag -- that caused
units not depending on the chrome/browser/ash/crosapi source set directly
(and therefore not importing the corresponding gni definition for this flag)
to provide invalid offsets for crosapi function calls.

(cherry picked from commit aac0d4b)

Bug: b/239445586
Change-Id: I7532db2a4a2c00b2cb736676c528543f62820dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781350
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Andrew Rayskiy <greengrape@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1028049}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3780931
Auto-Submit: Andrew Rayskiy <greengrape@google.com>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/branch-heads/5195@{#35}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd pushed a commit that referenced this issue Sep 29, 2022
@dgozman
ProfileDestroyer: allow custom force-destruction timeout
4a33041 
This is useful for automation scenarios where slow computers
may not be able to close all processes in two seconds, but
will eventually succeed.

Currently, we hit CHECK in ~ProfileDestroyer, most likely because
we force-destroy upon timeout of ~2 seconds. This change allows
automation profiles to provide a custom timeout that would be
enough to destroy all render process hosts.

(cherry picked from commit bcc5a28)

Bug: 1349150
Change-Id: Iadbd45a6e23c90b1dae43c23b3c4de7930727c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3821446
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1037431}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846107
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Auto-Submit: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/branch-heads/5249@{#35}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
@npm1
[M108][FedCM] Rename discovery file to well-known in console error me…
698e20a 
…ssage

(cherry picked from commit c6eb419)

Bug: 1356704
Change-Id: I56cae48ed69f5fb491ddd0401a7f40a861cab5ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3953123
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Nicolás Peña <npm@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1058948}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3961648
Cr-Commit-Position: refs/branch-heads/5359@{#35}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
Observe windowDidChangeScreen on Mac
7ae470b 
M1 Macs miss screen changes when dragging windows between identical external monitors; it seems likely that windowDidChangeBackingProperties may not fire on ARM in those cases.

This prospective fix observes windowDidChangeScreen and uses existing plumbing to update web-exposed info and fire events.

Visual property updates exit early when no cached screen information has changed, so firing additional notifications should not regress performance.

(cherry picked from commit 4ba4a3d)

Bug: 1400771
Change-Id: Iaa25011b5780a4e40a4035f5abfe51b81759fc1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4114743
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Auto-Submit: Mike Wasserman <msw@chromium.org>
Commit-Queue: Mike Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1085013}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4119762
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Commit-Position: refs/branch-heads/5481@{#35}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
@skobes-chromium
Fix scrolling in preserve-3d in non-overflowing OOPIF.
f31985b 
The post-unification cc hit test doesn't find a scroller inside a
transform-style: preserve-3d container, because the sorting context id
isn't set on the scrolling contents layer.

This patch addresses the issue by making IsInitialScrollHitTestReliable
reject the hit test.  The main thread identifies the correct scroller.
This matches how it is already working for non-OOPIF.

A TODO in LayerTreeImpl is added for making the cc hit test work.

(cherry picked from commit 6d9e682)

Bug: 1407697
Change-Id: I1d9652a49f88c9c17111b6f716c1dad8f9f0fc23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4193135
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1097660}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4206007
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{#35}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
@chlily1
[M112][DownloadBubble] Show the most recent 100 items
c86be4f 
This fixes a bug that occurs when the user has more than 100 recent
items. Previously, we were limiting to 100 before sorting by time,
and since there is no guarantee on the order of items returned from
DownloadManager, this resulted in an arbitrary set of 100 recent items,
which may not be the 100 *most* recent. This CL changes that to sort
the items before limiting to 100, thus returning the 100 most recent
items in all cases.

(cherry picked from commit 1b3509a)

Bug: 1418708
Change-Id: I42c888d2b31459dd3e406e12b30dd7f531ffe6da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4286047
Reviewed-by: Xinghui Lu <xinghuilu@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1109345}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296196
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Auto-Submit: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/branch-heads/5615@{#35}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
Record attribution registrations dropped in Incognito via common metrics
65da3ac 
We replace the Conversions.RegisterConversionAllowed and
Conversions.RegisterImpressionAllowed metrics with the combined
source/trigger result metrics of Conversions.SourceStoredStatus2,
Conversions.CreateReportStatus7, and
Conversions.AggregatableReport.CreateReportStatus3.

We achieve this by always creating the AttributionManagerImpl, even in
incognito mode, since that class already honors incognito mode for each
registration attempt. This also allows us to remove a number of nullptr
checks and to show the dropped registrations in the internals UI.

(cherry picked from commit 31be850)

Bug: 1427206
Change-Id: Icdd6f02c11cbec1929f226a3c4c18ac5bbd70409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4366381
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1121639}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4368369
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#35}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
@adangla
[iOS] Add close all inactive metrics
c5f0406 
This CL add user actions when user tap on 'Close All Inactive' button
from the bottom of the inactive tabs view and confirm by press the
'Close All' in the confirmation toast.

(cherry picked from commit 6d1cea7)

Fixed: 1440124
Change-Id: I53b223c386747bcaf08158b0f1eac33834d6d4bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4479532
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Aliona Dangla <alionadangla@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Louis Romero <lpromero@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1135949}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481995
Auto-Submit: Aliona Dangla <alionadangla@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/branch-heads/5735@{#35}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erkserkserks @blueboxd