Migrated to Sound Null Safety #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DevNico |
|
Alright haven't had much time recently due to work / exams. Will look at this again end of next week. |
|
Should be ready for review now. |
3 tasks
|
This PR is even more relevant with Flutter 2, anything I can help you test? |
SergeShkurko
suggested changes
Mar 5, 2021
lib/src/photo_view_wrappers.dart
Outdated
| @@ -191,7 +189,7 @@ class _ImageWrapperState extends State<ImageWrapper> { | |||
|
|
|||
| Widget _buildLoading(BuildContext context) { | |||
| if (widget.loadingBuilder != null) { | |||
| return widget.loadingBuilder(context, _imageChunkEvent); | |||
| return widget.loadingBuilder!(context, _imageChunkEvent!); | |||
There was a problem hiding this comment.
i got a non critical problem when use PhotoViewGallery.builder (console spam, but works normally)
═══════ Exception caught by widgets library ═══════════════════════════════════
The following _CastError was thrown building ImageWrapper(dirty, state: _ImageWrapperState#640ea):
Null check operator used on a null value
The relevant error-causing widget was
PdfView
lib/main.dart:79
When the exception was thrown, this was the stack
#0 _ImageWrapperState._buildLoading
package:photo_view/src/photo_view_wrappers.dart:192
#1 _ImageWrapperState.build
package:photo_view/src/photo_view_wrappers.dart:155
#2 StatefulElement.build
package:flutter/…/widgets/framework.dart:4612
#3 ComponentElement.performRebuild
package:flutter/…/widgets/framework.dart:4495
#4 StatefulElement.performRebuild
package:flutter/…/widgets/framework.dart:4667
...
════════════════════════════════════════════════════════════════════════════════
There was a problem hiding this comment.
I removed it must have overlooked that.
|
This is very helpful PR! Is there anything I can help? |
|
Thank you so much for this contribution and sorry for the dalay! |
renancaraujo
approved these changes
Mar 7, 2021
sidlatau
pushed a commit
to sidlatau/photo_view
that referenced
this pull request
Apr 6, 2021
* Migrated to Sound Null Safety * Null safety migration * Removed incorrect notnull operator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #374 this is my PR for the migration to Sound Null Safety. All tests pass but the example will not run in sound null safety mode until flutter_svg is migrated. I opened an issue about migration there as well.
Closes #374