maxNumberOfFiles when set from callback

[xd3v2]

Love the plugin!

I'm seeing a bug when attempting to set maxNumberOfFiles from fileuploadadd(), fileuploadadded(), or fileuploadchange().

When setting maxNumberOfFiles = 1, everything works as expected. When setting maxNumberOfFiles = 2 or more, I see the following:

1. Am allowed to select unlimited files if I choose one file at a time.
2. Am allowed to select maxNumberOfFiles+1 files when choosing multiple files at a time.

For point #2, I'm always able to select one more file than what is set in maxNumberOfFiles. E.g I'm allowed to select 3 files if maxNumberOfFiles = 2.

For me personally, I think this is the only issue preventing me from running multiple file inputs on the same form with different settings. Other relevant settings seem to be acting as expected when set via callbacks for each input field.

[blueimp]

From the support guidelines:

Please try to reproduce the problem with the Demo or with an unmodified setup. Problems with customizations should be posted to the support forum, especially for server-side problems.
Provide as much details about your test setup as possible (server information, browser and operating system versions).
Please also provide a JSFiddle to allow to reproduce the problem, if possible.

I'll close this issue for now, as I couldn't reproduce any problems with the maxNumberOfFiles setting and I suspect this to be more of a customization issue, which should be posted to the support forum.

Feel free to reopen if this should indeed be a bug in the library itself.

[xd3v2]

Ya...

Drop this into main.js of your unmodified demo. Then, select 4 files form your upload dialogue. And/or, select one file at a time. You'll see what I mean.

// Initialize the jQuery File Upload widget:
$('#fileupload').fileupload()
.bind('fileuploadadd', function (e, data) {
$('#fileupload').fileupload('option', 'maxNumberOfFiles', 2);
});

[blueimp]

I added the following note to the Options documentation:

The maxNumberOfFiles setting acts like an internal counter and will adjust automatically when files are uploaded or deleted. That is, if you set it to 2 and upload one file (successfully), it will be decreased to 1. If you delete one of the existing files, it will be increased again.

[xd3v2]

I don't think you're seeing the same issue...

1. With the above code, I can add infinite files to the uploader, if I select one at a time. The counter never prevents me from stopping.
2. Again with the above code, I can select 3 files for upload (maxNumberOfFiles+1). If I change maxNumberOfFiles to 3, I can select 4 files successfully. etc. etc.

[blueimp]

I hoped the above note would explain the behavior of the maxNumberOfFiles setting to you, but I think I need to explain it in more detail, my apologies.

It doesn't make sense to set maxNumberOfFiles to a static setting inside of the add callback (or any other callback for that matter), as it acts like an internal counter - it is not simply a static setting that is checked against, but a dynamic property for the current limit.

Basically, you can think of the way the maxNumberOfFiles setting is implemented as a counter which tells you

How many files can I still add before I reach the limit?

If you start with a maxNumberOfFiles setting of 2 and then add two files, it will be decreased to 0, which will prevent adding any more files.
If you then cancel one of the added files or delete one of the already uploaded files, the setting will be increased again.

Everything clear?

[xd3v2]

Ya, sorry that I'm not understanding something and thank you for taking the time to explain. I guess I'm just fundamentally missing the intent of maxNumberOfFiles.

To me, it works as expected, so long as it's not set inside a callback. However, by my skewed sense of logic, it should still act as a counter when set inside the add callback, which would actually allow for different settings on multiple upload fields within the same form. Instead, I get this strange maxNumberOfFiles + 1 scenario; or I get the infinite add scenario.

But... :)

Ok. If you say so. It's still a great plugin!!!

I'm 80% finished with adding this to a Wordpress + Gravity Forms implementation, but this maxNumberOfFiles is really putting the breaks on me. I'm not sure where to go from here...

Thanks for your time.

[xd3v2]

I think I'll add a static property somewhere, cuz I really want to finish this WP plugin. Thanks again!

[blueimp]

I think what you want to achieve can be done the following way:

$('#fileupload').on('fileuploadadd', function (e, data) {
    if ($.type($(this).fileupload('option', 'maxNumberOfFiles')) !== 'number') {
        $(this).fileupload(
            'option',
            'maxNumberOfFiles',
            data.fileInput.data('maxNumberOfFiles')
        );
    }
});

Then you add the attribute data-max-number-of-files to each of your input files, e.g.:

<input type="file" name="files[]" multiple="" data-max-number-of-files="2">

[xd3v2]

Dude. Though I've had several shots of Tequila, I think you're right! What can I say? Thank you! Gonna give it a shot tomorrow.

[omaribilal]

Hi thanks guys ,this really helpful, but still this solution make some issues on (drag and drop)
drag and drop is not functional try to grag image
No images has been uploaded
you got this error in the fire bug console
TypeError: data.fileInput is undefined
data.fileInput.data('maxNumberOfFiles')
any selution