Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ardupilot udp serial port fix #2626

Merged
merged 2 commits into from
May 28, 2024

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented May 24, 2024

Screenshot 2024-05-24 at 11 36 55

fix #2627

@Williangalvani Williangalvani marked this pull request as draft May 24, 2024 15:00
@Williangalvani Williangalvani changed the title frontend: AutopilotSerialConfiguration: tell user what are the supported formats Ardupilot udp serial port fix May 24, 2024
@Williangalvani Williangalvani marked this pull request as ready for review May 24, 2024 16:30
@joaoantoniocardoso
Copy link
Member

nothing like a consistent API :)

@joaoantoniocardoso
Copy link
Member

so, Ardupilot Manager here doesn't need to use the same description names as MAVLink endpoint types (see the class EndpointType above)?

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that there is indeed an inconsistent as pointed by @joaoantoniocardoso

@Williangalvani
Copy link
Member Author

Williangalvani commented May 28, 2024

so, Ardupilot Manager here doesn't need to use the same description names as MAVLink endpoint types (see the class EndpointType above)?

that is correct, these are not "Mavlink Endpoints". They are often not mavlink at all.

These are the serial port commandline arguments taken by ardupilot. which are [udp, udpin, tcp].
The ardupilot code could be updated to also take udpout, but that would only take effect in a future release.

@patrickelectric patrickelectric merged commit 865f565 into bluerobotics:master May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"udpclient:ip:pport" serial settings do not work in ArdupilotManager
3 participants