Ardupilot udp serial port fix #2626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Williangalvani
requested review from
patrickelectric,
joaoantoniocardoso and
JoaoMario109
Williangalvani
changed the title
|
nothing like a consistent API :) |
Williangalvani
force-pushed
the
serial_types_text
branch
from
ec569c3
to
dbc2e76
Compare
Williangalvani
force-pushed
the
serial_types_text
branch
from
dbc2e76
to
9ede559
Compare
|
so, Ardupilot Manager here doesn't need to use the same description names as MAVLink endpoint types (see the class EndpointType above)? |
patrickelectric
approved these changes
May 28, 2024
patrickelectric
requested changes
May 28, 2024
There was a problem hiding this comment.
It appears that there is indeed an inconsistent as pointed by @joaoantoniocardoso
that is correct, these are not "Mavlink Endpoints". They are often not mavlink at all. These are the serial port commandline arguments taken by ardupilot. which are [udp, udpin, tcp]. |
patrickelectric
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2627