Merge 5bb873f into 32025fb

Author: m-mcgowan

.github/actions/publish-coverage/report/report.py

@@ -58,8 +58,10 @@ def post_report(coverage, args):
     """Post coverage report to coveralls.io."""
     response = requests.post(URL, files={'json_file': json.dumps(coverage)},
                              verify=(not args.skip_ssl_verify))
+    
     try:
         result = response.json()
+        result['status'] = response.status_code
     except ValueError:
         result = {'error': 'Failure to submit data. '
                   'Response [%(status)s]: %(text)s' % {
@@ -86,16 +88,10 @@ def main():
                     print("Environment variable COVERALLS_REPO_TOKEN is required to upload coverage information")
                     exit(-1)
 
-            # Consume Codefresh CI specific environment variables _(if available)_
-            json_coverage_details['service_job_id'] = os.environ.get('CF_BUILD_ID')
-            if (json_coverage_details['service_job_id'] is not None):
-                json_coverage_details['service_name'] = "codefresh"
-            else:
-                json_coverage_details['service_name'] = ""
-                del json_coverage_details['service_job_id']
-
             # Post report to Coveralls.io
-            post_report(json_coverage_details, args)
+            if post_report(json_coverage_details, args)!=0:
+                exit(-2)
+            
 
 if __name__ == '__main__':
     main()

.github/workflows/coverage.yml

@@ -0,0 +1,31 @@
+name: Build and Test
+
+on:
+  push:
+    branches:
+    - '*'
+  pull_request:
+    branches:
+    - '*'
+
+
+jobs:
+  coverage:
+    name: coverage (ubuntu-18.04)
+    runs-on: ubuntu-18.04
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - name: Install dependencies
+        run: sudo apt-get update && sudo apt-get install -y lcov g++ valgrind
+      - name: test
+        run: ./test/run_all_tests.sh
+      - name: run lcov
+        run: lcov --capture --directory . --output-file lcov-all.info && lcov --remove lcov-all.info "*test*" "*mock*" -o lcov.info
+      - name: Coveralls
+        uses: coverallsapp/github-action@master
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          path-to-lcov: "./lcov.info"
+

.github/workflows/note-arduino-ci.yml

@@ -20,7 +20,4 @@ jobs:
         uses: ./.github/actions/run-tests-in-container
         env:
           COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
-      - name: Publish Test Coverage
-        id: publish_coverage
-        uses: ./.github/actions/publish-coverage
 

src/Not_Covered.cpp

@@ -0,0 +1,64 @@
+// This file is deliberately not covered. The PR can be thrown away once we validate that coveralls rejects it and accepts it when the code is removed. 
+
+#if 0
+
+unsigned int crc32b(unsigned char *message) {
+   int i, j;
+   unsigned int byte, crc, mask;
+
+   i = 0;
+   crc = 0xFFFFFFFF;
+   while (message[i] != 0) {
+      byte = message[i];            // Get next byte.
+      crc = crc ^ byte;
+      for (j = 7; j >= 0; j--) {    // Do eight times.
+         mask = -(crc & 1);
+         crc = (crc >> 1) ^ (0xEDB88320 & mask);
+      }
+      i = i + 1;
+   }
+   return ~crc;
+}
+
+
+unsigned int crc32b_2(unsigned char *message) {
+   int i, j;
+   unsigned int byte, crc, mask;
+
+   i = 0;
+   crc = 0xFFFFFFFF;
+   while (message[i] != 0) {
+      byte = message[i];            // Get next byte.
+      crc = crc ^ byte;
+      for (j = 7; j >= 0; j--) {    // Do eight times.
+         mask = -(crc & 1);
+         crc = (crc >> 1) ^ (0xEDB88320 & mask);
+      }
+      i = i + 1;
+   }
+   return ~crc;
+}
+
+unsigned int crc32b_3(unsigned char *message) {
+   int i, j;
+   unsigned int byte, crc, mask;
+
+   i = 0;
+   crc = 0xFFFFFFFF;
+   while (message[i] != 0) {
+      byte = message[i];            // Get next byte.
+      crc = crc ^ byte;
+      for (j = 7; j >= 0; j--) {    // Do eight times.
+         mask = -(crc & 1);
+         crc = (crc >> 1) ^ (0xEDB88320 & mask);
+      }
+      i = i + 1;
+   }
+   return ~crc;
+}
+
+void f(void) {
+
+}
+
+#endif

test/run_all_tests.sh

@@ -5,6 +5,7 @@ all_tests_result=0
 if [ 0 -eq $all_tests_result ]; then
   echo && echo 'Compiling and running Notecard Test Suite...'
   g++ -fprofile-arcs -ftest-coverage -Wall -Wextra -Werror -Wpedantic -std=c++11 -O0 -g \
+    src/Not_Covered.cpp \
     src/Notecard.cpp \
     test/Notecard.test.cpp \
     test/mock/mock-arduino.cpp \
@@ -32,6 +33,7 @@ fi
 if [ 0 -eq $all_tests_result ]; then
   echo && echo 'Compiling and running NoteI2c_Arduino Test Suite (no flags)...'
   g++ -fprofile-arcs -ftest-coverage -Wall -Wextra -Werror -Wpedantic -std=c++11 -O0 -g \
+    src/Not_Covered.cpp \
     src/NoteI2c_Arduino.cpp \
     test/NoteI2c_Arduino.test.cpp \
     test/mock/mock-arduino.cpp \
@@ -56,6 +58,7 @@ fi
 if [ 0 -eq $all_tests_result ]; then
   echo && echo 'Compiling and running NoteI2c_Arduino Test Suite (-DWIRE_HAS_END)...'
   g++ -fprofile-arcs -ftest-coverage -Wall -Wextra -Werror -Wpedantic -std=c++11 -O0 -g \
+    src/Not_Covered.cpp \
     src/NoteI2c_Arduino.cpp \
     test/NoteI2c_Arduino.test.cpp \
     test/mock/mock-arduino.cpp \
@@ -81,6 +84,7 @@ fi
 if [ 0 -eq $all_tests_result ]; then
   echo && echo 'Compiling and running NoteLog_Arduino Test Suite...'
   g++ -fprofile-arcs -ftest-coverage -Wall -Wextra -Werror -Wpedantic -std=c++11 -O0 -g \
+    src/Not_Covered.cpp \
     src/NoteLog_Arduino.cpp \
     test/NoteLog_Arduino.test.cpp \
     test/mock/mock-arduino.cpp \
@@ -104,6 +108,7 @@ fi
 if [ 0 -eq $all_tests_result ]; then
   echo && echo 'Compiling and running NoteSerial_Arduino Test Suite...'
   g++ -fprofile-arcs -ftest-coverage -Wall -Wextra -Werror -Wpedantic -std=c++11 -O0 -g \
+    src/Not_Covered.cpp \
     src/NoteSerial_Arduino.cpp \
     test/NoteSerial_Arduino.test.cpp \
     test/mock/mock-arduino.cpp \
@@ -129,20 +134,16 @@ if [ 0 -eq ${all_tests_result} ]; then
   echo && echo 'All tests have passed!'
   # Run coverage if available
   if [ $(which gcovr) ]; then
-    gcovr --print-summary --sort-percentage --exclude-throw-branches --delete \
+    echo "GITHUB_ACTIONS $GITHUB_ACTIONS"
+    echo "GITHUB_WORKFLOW $GITHUB_WORKFLOW"
+    echo "GITHUB_RUN_ID $GITHUB_RUN_ID"
+    echo "GITHUB_SHA $GITHUB_SHA"
+    gcovr --print-summary --sort-percentage --exclude-throw-branches \
       --object-directory . \
       --root src \
       --exclude .*_error.* \
       --exclude test \
-      --coveralls coverage.json \
-      --txt \
-    && rm ./a.out *.gcno
-    if [ ! -f "coverage.json" ]; then
-      echo "Coverage report not produced";
-      all_tests_result=997
-    fi
-  else
-    rm -f ./a.out *.gcda *.gcno
+      --txt 
   fi
 else
   echo && echo 'TESTS FAILED!!!' \