only include media posts by post creator #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
commented
Aug 17, 2023
| ) | ||
| feedItemsQb = feedItemsQb | ||
| // and only your own posts/reposts | ||
| .where('post.creator', '=', did) |
There was a problem hiding this comment.
This is the only query change in both PDS and App View
estrattonbailey
commented
Aug 17, 2023
| const isActorMedia = isImageEmbed(post.embed) | ||
| const isFromActor = post.author.did === carol | ||
|
|
||
| return (isRecordWithActorMedia || isActorMedia) && isFromActor |
There was a problem hiding this comment.
Tightened up these tests to ensure that the author is the actor in question
estrattonbailey
commented
Aug 17, 2023
| expect(danFeed.feed.length).toEqual(0) | ||
| }) | ||
|
|
||
| it('filters by posts_no_replies', async () => { |
There was a problem hiding this comment.
And split a test out
estrattonbailey
commented
Aug 17, 2023
Comment on lines
43
to
55
| let actorDid = '' | ||
| if (actor.startsWith('did:')) { | ||
| actorDid = actor | ||
| } else { | ||
| const actorRes = await ctx.db.db | ||
| .selectFrom('did_handle') | ||
| .select('did') | ||
| .where('did_handle.handle', '=', actor) | ||
| .executeTakeFirst() | ||
| if (actorRes) { | ||
| actorDid = actorRes?.did | ||
| } | ||
| } |
There was a problem hiding this comment.
Moved this out of getFeedItemsQb using the same approach as the App View
dholms
reviewed
Aug 17, 2023
dholms
approved these changes
Aug 17, 2023
dholms
reviewed
Aug 17, 2023
dholms
approved these changes
Aug 17, 2023
|
Sweet! |
mloar
pushed a commit
to mloar/atproto
that referenced
this pull request
Nov 15, 2023
…167-media-reposts only include media posts by post creator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bluesky-social/social-app#1167