Add basic application rate limits to appview #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
approved these changes
Dec 5, 2023
estrattonbailey
added a commit
that referenced
this pull request
Dec 8, 2023
…hould-show-own-threads * origin: Version packages (#1945) Strip trailing colons from link detection, add test (#1944) Add labels to actor search typeahead results (#1940) Version packages (#1938) Bump api package for no-unauthenticated PR (#1937) Add !no-unauthenticated imperative label (#1926) Fail open on did cache (#1934) Appview rate limits parse cidr block (#1932) Tweak rate limit cfg (#1931) Set trust proxy on appview for xff headers (#1930) Transfer with-friends & best-of-follows to feed generator (#1919) Add basic application rate limits to appview (#1902) Cache tweaks (#1929) Fix typo in service entry Import redis in service entry Cache labels in Redis (#1897) ♻️ Cleanup linter warnings (#1907) fix(bsky): cf image invalidator not taken into account when bunny used (#1823) pre-compile handlebar templates at build time (#1833) feat: infer definition type from "types" argument in getDefOrThrow (#1812)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have redis in the mix, this adds two basic global rate limits to the appview:
Note: we need to ensure we don't rate limit the CDN