Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSuggestionsSkeleton lexicon #2399

Merged
merged 11 commits into from
Apr 16, 2024
Merged

getSuggestionsSkeleton lexicon #2399

merged 11 commits into from
Apr 16, 2024

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Apr 10, 2024

Adds a schema for getSuggestionsSkeleton

Return values are of type app.bsky.actor.defs#skeletonActor which is just a wrapper object around did but leaves us room to add some annotations in the future if we need to

Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! My only question is whether app.bsky.actor.getSuggestionsSkeleton should be unspecced similar to other non-public backing endpoints such as app.bsky.unspecced.searchActorsSkeleton.

@dholms dholms merged commit 45981de into main Apr 16, 2024
10 checks passed
@dholms dholms deleted the suggestions-skeleton branch April 16, 2024 18:50
estrattonbailey added a commit that referenced this pull request Apr 29, 2024
* origin/main: (23 commits)
  Feed context & sendInteractions impl (#2402)
  Pass through topics headers (#2447)
  Version packages (#2446)
  ✨ Allow muting reporter (#2390)
  Version packages (#2443)
  Add `savedFeedsPrefV2` and new methods (#2427)
  fix(ozone): properly import "lande" ES module (from CJS) (#2441)
  Appview: remove replies to blocked posts from feeds (#2430)
  PDS: handle S3 upload timeout more gracefully (#2429)
  Appview: maintain language info when going out to a suggestions service (#2424)
  Appview: ensure hydration context tracks viewer did and not full service ref (#2423)
  ✨ Detect language from record content if lang property is not set (#2301)
  Version packages (#2422)
  Add email auth factor tools to API (#2419)
  Version packages (#2417)
  Lexicons: email auth factor (#2416)
  Suggestions skeleton impl (#2403)
  getSuggestionsSkeleton lexicon (#2399)
  Version packages (#2401)
  Appview: support new post search params, viewer context in search (#2409)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants