fix(api): hasMutedWord for facets with multiple features
#2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sugyan
changed the title
hasMutedWord for facets with multiple featureshasMutedWord for facets with multiple features
sugyan
added a commit
to sugyan/atrium
that referenced
this pull request
Jun 19, 2024
sugyan
added a commit
to sugyan/atrium
that referenced
this pull request
Jun 19, 2024
* Add moderation methods * Add extra_data... * Add Object<T> for object types * Fix README * Fix tests * Remove unnecessary clone() and into() * Fix ModerationPrefs deserializer * Fix has_muted_word bluesky-social/atproto#2570 * Add ThreadViewPreference
Merged
estrattonbailey
added a commit
that referenced
this pull request
Jul 26, 2024
…cements * origin/main: Use default Statsig export (#2660) remove link to invite code form (#2655) Version packages (#2652) Priority notification setting (#2648) fix(api): `hasMutedWord` for facets with multiple features (#2570) Appview: enable insight into full thread context (#2651) 🐛 include takedowns in post thread for admins (#2642)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasMutedWordfunction used in moderation uses the value of the tag in the facets passed as an argument astagsfor judging. The current implementation was to “add the 0th of the features to thetagsif a feature corresponding toisTagis found”.This is incorrect,
featuresis an array that can contain multiple elements, and those of type#tagcan be included after the first. The 0th element can be hidden by a tag that is not the target word of the mute, or it can be a completely unrelated type.Actually, it is possible to create such a post (e.g. https://bsky.app/profile/sugyan.pds.shigepon.net/post/3kukmykhshk2l), and an error will occur if a user with
mutedWordsset tries to view it.Fixed it so all
#tagtypes infeaturesare subject to the decision, and added a test.