[Detach] Lexicons #2664
Merged
[Detach] Lexicons #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
reviewed
Jul 30, 2024
dholms
reviewed
Jul 30, 2024
|
Snuck in some protos here too 👍 |
Merged
bnewbold
reviewed
Aug 1, 2024
| "main": { | ||
| "type": "record", | ||
| "key": "tid", | ||
| "description": "Record defining post URIs detached from a root post. The record key (rkey) of the detach record must match the record key of the root post in question, and that record must be in the same repository.", |
There was a problem hiding this comment.
"detaching" works against both replies and quote-posts, right? either way we should probably clarify here in the description was "detatch" actually means.
| "post": { | ||
| "type": "string", | ||
| "format": "at-uri", | ||
| "description": "Reference (AT-URI) to the post record." |
There was a problem hiding this comment.
"Reference (AT-URI) to the original post record"
| }, | ||
| "description": "List of detached post URIs." | ||
| }, | ||
| "updatedAt": { "type": "string", "format": "datetime" } |
There was a problem hiding this comment.
I assume this should get updated every time posts are added or removed from the targets array? should clarify in description.
| }, | ||
| "targets": { | ||
| "type": "array", | ||
| "maxLength": 50, |
There was a problem hiding this comment.
you said "1k" in the PR description, but only 50 here; was that intentional? either is probably ok/plausible to me, if I was painting the bike shed i'd probably go with 200
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
app.bsky.feed.detachlexicon and codegens.targetslimit set to 1k for now.