Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't return profiles in reference lists/starter packs that have a block relationship with the owner #2713

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Don't return profiles in reference lists/starter packs that have a block relationship with the owner #2713

merged 12 commits into from
Aug 16, 2024

Conversation

haileyok
Copy link
Contributor

No description provided.

@haileyok haileyok changed the title don't hydrate profiles in reference lists/starter packs that have a block relationship with the owner Don't hydrate profiles in reference lists/starter packs that have a block relationship with the owner Aug 14, 2024
@haileyok haileyok changed the title Don't hydrate profiles in reference lists/starter packs that have a block relationship with the owner Don't return profiles in reference lists/starter packs that have a block relationship with the owner Aug 14, 2024
@haileyok haileyok marked this pull request as ready for review August 14, 2024 02:48
@haileyok haileyok force-pushed the hailey/no-blocks-ref-list branch from 4c29ded to fa836f4 Compare August 14, 2024 02:50
devinivy
devinivy reviewed Aug 14, 2024
View reviewed changes
packages/bsky/src/api/app/bsky/graph/getList.ts
@@ -88,6 +114,31 @@ const presentation = (
return { list, items, cursor }
}

const maybeGetBlocksForReferenceList = async (input: {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need similar logic in app.bsky.graph.getStarterPack for starterPack.listItemsSample.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added something for that, tell me if it makes sense or not - seemed to me to make the most sense to handle it inside of hydrateStarterPacks().

@haileyok haileyok force-pushed the hailey/no-blocks-ref-list branch from 7115c59 to 82dc44a Compare August 14, 2024 06:41
devinivy
devinivy approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👍

@devinivy devinivy merged commit 17e2d29 into main Aug 16, 2024
10 checks passed
@devinivy devinivy deleted the hailey/no-blocks-ref-list branch August 16, 2024 15:54
estrattonbailey added a commit that referenced this pull request Aug 16, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into reply-qp-moderation
594cf9b 
* origin/main:
  Don't return profiles in reference lists/starter packs that have a block relationship with the owner  (#2713)
  ⚡ Add index on createdAt column on moderation_event table (#2716)
haileyok added a commit that referenced this pull request Aug 16, 2024
@haileyok
Don't return profiles in reference lists/starter packs that have a bl…
058f647 
…ock relationship with the owner (#2713)

* proposal

* clean

* create seed

* type

* update tests

* change pairs

* `maybeGetBlocksForReferenceList`

* add logic for filtering inside of `getStarterPack()`

* move seeding to test

* nits

* tweak getting blocks

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haileyok @devinivy