Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-standard *_endpoint_auth_method #2729

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Remove non-standard *_endpoint_auth_method #2729

merged 1 commit into from
Aug 20, 2024

Conversation

matthieusieben
Copy link
Contributor

@matthieusieben matthieusieben commented Aug 20, 2024 •
edited
Loading

The use of <name>_endpoint_auth_method was inspired by https://github.com/panva/node-oidc-provider. This is however non-standard behavior that was removed in node-oidc-provider.

This PR removes that code from our oauth implementation

devinivy
devinivy approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@matthieusieben matthieusieben merged commit 35a1264 into main Aug 20, 2024
10 checks passed
@matthieusieben matthieusieben deleted the msieben/oauth-fixes branch August 20, 2024 15:26
@github-actions github-actions bot mentioned this pull request Aug 20, 2024
Merged
estrattonbailey added a commit that referenced this pull request Aug 20, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into reply-qp-moderation
a0974c3 
* origin/main:
  Compute 3p blocks for `ReplyRef.root` (#2721)
  Version packages (#2726)
  Remove non-standard *_endpoint_auth_method (#2729)
  Allow charset in content-type header of incoming requests (#2728)
  Remove "exp" from DPoP proofs (#2727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthieusieben @devinivy