Follow-on cleanup after #2483 #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lindner
commented
Sep 27, 2024
lindner
commented
- Change tests to use AtpClient instead of the deprecated BskyClient
- Change tests to use AtpClient instead of the deprecated BskyClient
|
docker/CI/github have been really struggling recently; I think the CI failures are due to infra issues for now. Will need to loop back after a few hours for the infra issues to settle and retry those runs. |
|
Looks like all tests pass. Looking forward to more PRs :-D |
matthieusieben
approved these changes
Sep 28, 2024
|
There is so much deprecated stuff that was introduced with that change.. thanks for helping us get rid of it 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.