🚧 OAuth - Client SDK #2483
Merged
🚧 OAuth - Client SDK #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
force-pushed
the
feat-oauth-client
branch
from
69632ad to
b8192c6
Compare
Closed
matthieusieben
force-pushed
the
feat-oauth-client
branch
2 times, most recently
from
b81c5a4 to
305c8f9
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
from
ccd2983 to
bf7018d
Compare
matthieusieben
force-pushed
the
feat-oauth-client
branch
3 times, most recently
from
ed16b2c to
f86a48c
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
4 times, most recently
from
1e2650f to
0a1e434
Compare
matthieusieben
force-pushed
the
feat-oauth-client
branch
5 times, most recently
from
d481f72 to
22ac587
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
from
0a1e434 to
1c9d30e
Compare
matthieusieben
force-pushed
the
feat-oauth-client
branch
from
22ac587 to
cda616b
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
2 times, most recently
from
5f7493f to
931d1d6
Compare
matthieusieben
force-pushed
the
feat-oauth-client
branch
from
cda616b to
493b394
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
from
931d1d6 to
aa21f13
Compare
matthieusieben
force-pushed
the
feat-oauth-client
branch
from
493b394 to
f84f085
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
from
aa21f13 to
a9ee31b
Compare
matthieusieben
force-pushed
the
feat-oauth-client
branch
from
f84f085 to
762a375
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
from
aa5258b to
d3f5b47
Compare
matthieusieben
force-pushed
the
feat-oauth-client
branch
from
762a375 to
c916809
Compare
matthieusieben
force-pushed
the
feat-oauth-server
branch
from
d3f5b47 to
da94447
Compare
matthieusieben
commented
Aug 7, 2024
bnewbold
reviewed
Aug 9, 2024
Comment on lines
+60
to
+62
| - The `AtpBaseClient` has been removed. The `AtpServiceClient` has been renamed | ||
| `AtpBaseClient`. Any code using either of these classes will need to be | ||
| updated. |
There was a problem hiding this comment.
This reads a little confusing: there is still a AtpBaseClient, but the old implementation was removed and replaced with what was formerly called AtpServiceClient?
There was a problem hiding this comment.
Yes! I guess I could revert the renaming ...
There was a problem hiding this comment.
I don't mean change the code, just re-phrase this sentence.
matthieusieben
force-pushed
the
feat-oauth-client
branch
from
dcc466d to
7064f5a
Compare
devinivy
approved these changes
Aug 12, 2024
Merged
estrattonbailey
added a commit
that referenced
this pull request
Aug 15, 2024
* origin/main: Provide a ponyfill for CustomEvent (#2710) Ensure presence of DPoP related response headers (#2711) prettier ignore changelogs, as changesets not resolving prettier config properly Version packages (#2709) Export `AtpAgentOptions` type from @atproto/api (#2708) tidy Version packages (#2706) Update changeset to better reflect changes (#2707) Client SDK rework (#2483) Allow aud of pds or entryway for service auth tokens on pds (#2694) Version packages (#2692) Lex-cli prettier changes changeset (#2691) Version packages (#2689) PDS - inspect bearer tokens (#2688) Version packages (#2685) Service auth method binding - PDS (#2668) minor typos in descriptions and comments (#2681) Fix run-dev-env-logged command (#2682) Version packages (#2677) Tweak some wording in `oauth-client-browser` readme (#2678)
haileyok
added a commit
that referenced
this pull request
Aug 16, 2024
* feat(api): support creation of oauth based AtpAgents * oauth: misc fixes for confidential clients * fix(xprc): remove ReadableStream.from polyfill * OAuth docs tweaks (#2679) * OAuth: clarification about client_name being shown * OAuth: re-write handle resolution privacy concern * avoid relying on ReadableStream.from in xrpc-server tests * feat(oauth-types): expose "ALLOW_UNSECURE_ORIGINS" constant * feat(handle-resolver): expose "AtprotoIdentityDidMethods" type * fix(oauth-client): ensure that the oauth metadata document contains client_id_metadata_document_supported * fix(oauth-types): prevent unknown query string in loopback client id * fix(identity-resolver): check that handle is in did doc's "alsoKnownAs" * feat(oauth-client:oauth-resolver): allow logging in using either the PDS URL or Entryway URL * fix(oauth-client): return better error in case of invalid "oauth-protected-resource" status code * refactor(did): group atproto specific checks in own * feat(api): relax typing of "appLabelers" and "labelers" AtpClient properties * allow any did as labeller (for tests mainly) * fix(api): allow to override "atproto-proxy" on a per-request basis * remove release candidate versions from changelog * update changeset for api and xrpc packages * Add missing changeset * revert RC versions * Proper wording in OAUTH.md api example * remove "pre" changeset file * xrpc: restore original behavior of setHEader and unsetHeader * docs: add comment for XrpcClient 's constructor arg * feat(api): expose "schemas" publicly * feat(api): allow customizing the whatwg fetch function of the AtpAgent * docs(api): improve migration docs * docs: change reference to BskyAgent to AtpAgent * docs: mention the breaking change regarding setSessionPersistHandler * fix(api): better split AtpClient concerns * fix(xrpc): remove unused import * refactor(api): simplify class hierarchu by removeing AtpClient * fix(api): mock proper method for facets detection * restore ability to restore session asynchronously * feat(api): allow instantiating Agent with same argument as super class * docs(api): properly extend Agent class * style(xrpc): var name * docs(api): remove "async" to header getter --------- Co-authored-by: Devin Ivy <devinivy@gmail.com> Co-authored-by: bnewbold <bnewbold@robocracy.org> Co-authored-by: Hailey <me@haileyok.com>
lindner
added a commit
to lindner/atproto
that referenced
this pull request
Sep 27, 2024
- Change tests to use AtpClient instead of the deprecated BskyClient
matthieusieben
pushed a commit
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new implementation of the
@aproto/apipackage that makes it ready for being used with OAuth based credentials.