Lexicon: languages on starter pack, feed gen, and labeler records #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,12 @@ | |||
| "description": "Self-label values", | |||
| "refs": ["com.atproto.label.defs#selfLabels"] | |||
| }, | |||
| "langs": { | |||
| "type": "array", | |||
| "description": "Indicates the human language for the intended audiences of the feed generator.", | |||
There was a problem hiding this comment.
Should we mention the format here? Like pry leave it open, but specify at least BCP-47 with or without region codes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds optional
langsfields on starter pack, feed gen, and labeler records. This is in line with thelangsfield on post records, and should provide more signal on relevance for discovery mechanisms in the app.