Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode on application startup #2292

Closed
maisondasilva opened this issue Dec 24, 2023 · 18 comments
Closed

Dark mode on application startup #2292

maisondasilva opened this issue Dec 24, 2023 · 18 comments
Assignees
Labels
feature-request A request for a new feature x:planned We're on it!

Comments

@maisondasilva
Copy link
Contributor

It would be nice to have an image with a darker background for those who use dark mode activated, because at night when opening the application it displays a bright image!

Imagem do WhatsApp de 2023-12-24 à(s) 11 21 11_c3856e46

@maisondasilva maisondasilva added the feature-request A request for a new feature label Dec 24, 2023
@pfrazee pfrazee added the x:discussing We've seen the request and we're talking about it! label Dec 27, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Dec 27, 2023

we'll have to see if that's possible. the splash is registered with the operating system and we may not be able to control it

@ansh
Copy link
Contributor

ansh commented Dec 30, 2023

We can do this via the ios.splash.dark flag in iOS and its equivalent in Android

https://docs.expo.dev/versions/latest/config/app

@pfrazee Im happy to take this on. Will be fun!

@ansh ansh self-assigned this Dec 30, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented Jan 2, 2024

@ansh go for it

@pfrazee pfrazee added x:planned We're on it! and removed x:discussing We've seen the request and we're talking about it! labels Jan 2, 2024
@estrattonbailey estrattonbailey self-assigned this Jan 8, 2024
@pfrazee
Copy link
Collaborator

pfrazee commented Jan 9, 2024

Closed by #2448

@pfrazee pfrazee closed this as completed Jan 9, 2024
@benharri
Copy link
Contributor

There's still a full white screen before the splash image loads. I'm not seeing splash.dark changed in that PR

@scottdotweb
Copy link

I think this issue should be reopened. This post by @mukuuji.bsky.social demonstrates why:

bafkreidmvtj6xguczgxc6l3esds7aekk6gai2epxr7v2mz2hirebue45ru

To be slightly less tongue in cheek, for me as an Android user in dark mode, what I see after tapping the app icon is:

  1. Dark blue screen with blue/white app icon
  2. brief fade to completely white screen
  3. night sky with stars
  4. white butterfly appears
  5. butterfly zooms to full white screen
  6. fade to black dark mode of app.

So that's dark, full brightness, dark, full brightness, dark. It's actually quite unpleasant and I now tend to look away until the app is fully loaded. :(

@estrattonbailey
Copy link
Member

estrattonbailey commented Feb 16, 2024

Update here, we've tweaked this again, and the butterfly is now a deep, almost-black blue. Should prevent blinding users. Will be included in next release, pending any further changes 👍

I don't think we've seen # 2 before, I'll note that and investigate. Thanks for the details on that!

@scottdotweb
Copy link

Thank you! I've got a screen recording of the app starting up if you need a demo.

@estrattonbailey
Copy link
Member

Oh that would be awesome if you don't mind uploading here 🙏

@benharri
Copy link
Contributor

screen-20240216-151222.2.mp4

here's a quick recording of both white flashes on cold startup. Android 14, pixel 6a

@scottdotweb
Copy link

scottdotweb commented Feb 16, 2024

Thanks Ben, that matched what I get. Android 14, Samsung Galaxy S23 Ultra.

@maisondasilva
Copy link
Contributor Author

maisondasilva commented Feb 16, 2024

I see a white image before the butterfly on my Samsung

Screen_Recording_20240216_174335_Bluesky.mp4

@estrattonbailey
Copy link
Member

Thanks y'all! Really appreciate it. We'll have a closer look 👍

@maisondasilva
Copy link
Contributor Author

@estrattonbailey I think this could be opened again?

@estrattonbailey
Copy link
Member

Oh sure! I'll keep myself assigned

@parion
Copy link

parion commented Mar 2, 2024

The latest update definitely helps by making the butterfly logo dark blue for dark mode users, but the white image described by @maisondasilva still exists.

@maisondasilva
Copy link
Contributor Author

@parion Thanks
Yes, it was very good but I can confirm that there is still a white image

@haileyok
Copy link
Contributor

haileyok commented Mar 6, 2024

This should be fixed now from #3105. Please feel free to ping if it isn't in the next (not the one today/tomorrow but the next) update!

Huge thanks to @edo-bari-ikutsu

@haileyok haileyok closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature x:planned We're on it!
Projects
None yet
Development

No branches or pull requests

8 participants