-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode on application startup #2292
Comments
we'll have to see if that's possible. the splash is registered with the operating system and we may not be able to control it |
We can do this via the https://docs.expo.dev/versions/latest/config/app @pfrazee Im happy to take this on. Will be fun! |
@ansh go for it |
Closed by #2448 |
There's still a full white screen before the splash image loads. I'm not seeing splash.dark changed in that PR |
I think this issue should be reopened. This post by To be slightly less tongue in cheek, for me as an Android user in dark mode, what I see after tapping the app icon is:
So that's dark, full brightness, dark, full brightness, dark. It's actually quite unpleasant and I now tend to look away until the app is fully loaded. :( |
Update here, we've tweaked this again, and the butterfly is now a deep, almost-black blue. Should prevent blinding users. Will be included in next release, pending any further changes 👍 I don't think we've seen # 2 before, I'll note that and investigate. Thanks for the details on that! |
Thank you! I've got a screen recording of the app starting up if you need a demo. |
Oh that would be awesome if you don't mind uploading here 🙏 |
screen-20240216-151222.2.mp4here's a quick recording of both white flashes on cold startup. Android 14, pixel 6a |
Thanks Ben, that matched what I get. Android 14, Samsung Galaxy S23 Ultra. |
I see a white image before the butterfly on my Samsung Screen_Recording_20240216_174335_Bluesky.mp4 |
Thanks y'all! Really appreciate it. We'll have a closer look 👍 |
@estrattonbailey I think this could be opened again? |
Oh sure! I'll keep myself assigned |
The latest update definitely helps by making the butterfly logo dark blue for dark mode users, but the white image described by @maisondasilva still exists. |
@parion Thanks |
This should be fixed now from #3105. Please feel free to ping if it isn't in the next (not the one today/tomorrow but the next) update! Huge thanks to @edo-bari-ikutsu |
It would be nice to have an image with a darker background for those who use dark mode activated, because at night when opening the application it displays a bright image!
The text was updated successfully, but these errors were encountered: