Improve splash display on android #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2292. Also fwiw I think the white screen on startup is only an issue on Android. In my experience, iOS displays the splash image (starry sky or blue sky) immediately after opening the app. I also couldn't find any issues reporting the white screen pre-splash on iOS. |
|
Another awesome PR! Yup, this isn't an issue on iOS. Wasn't aware of this expo config plugin at all, thank you so much for sharing! |
|
@edo-bari-ikutsu By the way, this is definitely something that might be worth bringing up in the @expo repo if you feel like it. Seems to be something that a ton of people run into! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Android app displays a white screen before the splash screen. A white status bar is also displayed. I think this white display degrades the user experience of the app (especially on dark mode).
By applying this fix, white display is gone and startup and splash become more continuous and natural.
Note: this fix is only for Android apps, as I don't have iOS devices. To avoid side effects to the iOS app, I have applied some conditional branches and code separation between Android and iOS.
SPLASH_CONFIGandDARK_SPLASH_CONFIGinapp.config.js,SPLASH_CONFIG_ANDROIDandDARK_SPLASH_CONFIG_ANDROIDadded.<StatusBar />in App.native.tsx is only added on Android.