Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds profile media tab #1137

Merged
merged 8 commits into from
Aug 10, 2023
Merged

Adds profile media tab #1137

merged 8 commits into from
Aug 10, 2023

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Aug 8, 2023

Depends on #1141 for the @atproto/api@0.6.0 integration.

Adds a "Media" tab to the profile screen, and replaces the client-side filtering of replies with a server-side filter. Further UI work for this view will come as a follow-up.

Screen.Recording.2023-08-08.at.3.10.56.PM.mov

@estrattonbailey estrattonbailey marked this pull request as ready for review August 8, 2023 20:13
@estrattonbailey estrattonbailey force-pushed the eric/app-787-media-tab branch from 91b73b8 to 4531efd Compare August 9, 2023 23:33
@pfrazee
Copy link
Collaborator

pfrazee commented Aug 10, 2023

Okay this is looking great, two things we need address:

  1. Switching tabs on mobile is a bit screwy. The loading state causes the spinner to show up briefly, jogging the UI a bit. We do need to indicate the loading state. There's a couple ways to handle this; it might be worth having 3 different feed models rather than swapping out the one.
  2. Mobile now has the ability to overflow the tab headers (smaller devices and/or larger accessibility text). We can fix that either by using a scrollview or by trying to simplify the tab names (eg "Post & replies" -> "w/Replies")

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice work!

@pfrazee pfrazee merged commit cc3fcb1 into main Aug 10, 2023
@pfrazee pfrazee deleted the eric/app-787-media-tab branch August 10, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants