Add alerts to embeds #1138
Merged
Add alerts to embeds #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embeds currently don't have alerts when they should:
This PR fixes that:
This also applies to a "downgrading" behavior† which applies to self quote posts:
† Moderation UI "downgrades" from filters & blurs to just alerts for your own content. This is to avoid confusingly absent content, but it's currently a little inconsistent -- it correctly downgrades on quote posts but not on images. I'm going to tweak this behavior a bit, but for now it's useful to get this fix done.