Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email verification and change flows #1560

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Email verification and change flows #1560

merged 12 commits into from
Sep 28, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Sep 27, 2023

  • Adds email verification flow
  • Adds email change flow
  • Adds a reminder on app load to verify email if not verified. Reminder only shows once a day and shards the users into 2 days of the week to get it, to avoid nagging too much and to avoid everybody running the flow all at once.

Settings

CleanShot 2023-09-27 at 15 30 43@2x

Verify flow

CleanShot 2023-09-27 at 15 30 52@2x CleanShot 2023-09-27 at 15 31 04@2x

Change flow

CleanShot 2023-09-27 at 15 31 43@2x CleanShot 2023-09-27 at 15 31 57@2x CleanShot 2023-09-27 at 15 32 16@2x

Reminder on app open

CleanShot 2023-09-27 at 15 32 43@2x

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nit on the auto* attributes.

Could probably clarify the error copy when trying to change your email prior to having first verified the current email. Rn it just says confirmation token required, but really it's You must first verify your current email before changing it.

Comment on lines +9 to +13
// NOTE
// by defaulting to the current date, we ensure that the user won't be nagged
// on first run (aka right after creating an account)
// -prf
lastEmailConfirm: Date = new Date()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pfrazee
Copy link
Collaborator Author

pfrazee commented Sep 28, 2023

Could probably clarify the error copy when trying to change your email prior to having first verified the current email.

Done

@pfrazee pfrazee merged commit cd3b0e5 into main Sep 28, 2023
@pfrazee pfrazee deleted the email-confirmation branch September 28, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants