-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email verification and change flows #1560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nit on the auto* attributes.
Could probably clarify the error copy when trying to change your email prior to having first verified the current email. Rn it just says confirmation token required
, but really it's You must first verify your current email before changing it.
// NOTE | ||
// by defaulting to the current date, we ensure that the user won't be nagged | ||
// on first run (aka right after creating an account) | ||
// -prf | ||
lastEmailConfirm: Date = new Date() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Done |
Settings
Verify flow
Change flow
Reminder on app open