Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account quick switch modal #1567

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Account quick switch modal #1567

merged 5 commits into from
Sep 28, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Sep 28, 2023

Supercedes #1555

Closes #1514

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Idea: kinda want a lil haptic beep-beep when the sheet opens. Instagram does this well in the same use case.

@mozzius
Copy link
Member

mozzius commented Sep 28, 2023

Yeah agreed - I left it out because Twitter doesn't do it, but it would definitely make it much more satisfying

@pfrazee
Copy link
Collaborator Author

pfrazee commented Sep 28, 2023

I added a small haptic feedback but not as cool as instagram (which does an additional one to indicate the long press has triggered, then another on release)

@pfrazee pfrazee force-pushed the mozzius-quick-switch-account branch from ce6e7c8 to bfe8261 Compare September 28, 2023 19:35
@pfrazee pfrazee merged commit 2e5f73f into main Sep 28, 2023
4 checks passed
@pfrazee pfrazee deleted the mozzius-quick-switch-account branch September 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long press profile tab to quick switch accounts
3 participants