Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad support #1569

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

iPad support #1569

wants to merge 4 commits into from

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Sep 28, 2023

Start of iPad support. Unfortunately this is slightly less trivial than expected, though still doable. The web versions of the various components support the tablet form (decently) but the native versions all currently expect the mobile form-factor. Updating things to work correctly with the native tablet may be a task best left for a future refactor, such as when we introduce the design system.

How this looks currently:

CleanShot 2023-09-28 at 14 09 40@2x

This also fixes the authentication flow:

Simulator Screenshot - iPad Pro (11-inch) (4th generation) - 2024-03-31 at 17 00 34

Test plan

This PR is the absolute basics of iPad support - basically just enabling it and making sure it's not entirely broken.

  1. does it boot up into iPad
  2. does the auth flow work
  3. is the auth flow still working on other platforms

Note that the header overlaps with the feed - this is fixed in #3465

Copy link

The Pull Request introduced fingerprint changes against the base commit: 0ff7e71

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "node_modules/react-native-ui-text-view",
    "reasons": [
      "bareRncliAutolinking"
    ],
    "hash": "2320a1f2e90d5f30570b43028d81903fa8ffe4af"
  },
  {
    "type": "contents",
    "id": "expoConfig",
    "contents": "{\"android\":{\"adaptiveIcon\":{\"backgroundColor\":\"#1185FE\",\"backgroundImage\":\"./assets/icon-android-background.png\",\"foregroundImage\":\"./assets/icon-android-foreground.png\",\"monochromeImage\":\"./assets/icon-android-foreground.png\"},\"googleServicesFile\":\"./google-services.json\",\"icon\":\"./assets/icon.png\",\"intentFilters\":[{\"action\":\"VIEW\",\"autoVerify\":true,\"category\":[\"BROWSABLE\",\"DEFAULT\"],\"data\":[false,{\"host\":\"bsky.app\",\"scheme\":\"https\"}]}],\"package\":\"xyz.blueskyweb.app\",\"splash\":{\"backgroundColor\":\"#0c7cff\",\"dark\":{\"backgroundColor\":\"#0f141b\",\"image\":\"./assets/splash-dark.png\",\"resizeMode\":\"cover\"},\"image\":\"./assets/splash.png\",\"resizeMode\":\"cover\"}},\"androidStatusBar\":{\"backgroundColor\":\"#00000000\",\"barStyle\":\"light-content\"},\"extra\":{\"eas\":{\"build\":{\"experimental\":{\"ios\":{\"appExtensions\":[{\"bundleIdentifier\":\"xyz.blueskyweb.app.Share-with-Bluesky\",\"entitlements\":{\"com.apple.security.application-groups\":[\"group.app.bsky\"]},\"targetName\":\"Share-with-Bluesky\"}]}}},\"projectId\":\"55bd077a-d905-4184-9c7f-94789ba0f302\"}},\"hooks\":{\"postPublish\":[{\"config\":{\"dist\":\"undefined.1.75.0.undefined\",\"organization\":\"blueskyweb\",\"project\":\"react-native\",\"release\":\"1.75.0\"},\"file\":\"sentry-expo/upload-sourcemaps\"}]},\"icon\":\"./assets/icon.png\",\"ios\":{\"associatedDomains\":[\"applinks:bsky.app\",\"applinks:staging.bsky.app\"],\"bundleIdentifier\":\"xyz.blueskyweb.app\",\"config\":{\"usesNonExemptEncryption\":false},\"entitlements\":{\"com.apple.security.application-groups\":\"group.app.bsky\"},\"infoPlist\":{\"NSCameraUsageDescription\":\"Used for profile pictures, posts, and other kinds of content.\",\"NSMicrophoneUsageDescription\":\"Used for posts and other kinds of content.\",\"NSPhotoLibraryAddUsageDescription\":\"Used to save images to your library.\",\"NSPhotoLibraryUsageDescription\":\"Used for profile pictures, posts, and other kinds of content\",\"UIBackgroundModes\":[\"remote-notification\"]},\"splash\":{\"backgroundColor\":\"#ffffff\",\"dark\":{\"backgroundColor\":\"#001429\",\"image\":\"./assets/splash-dark.png\",\"resizeMode\":\"cover\"},\"image\":\"./assets/splash.png\",\"resizeMode\":\"cover\"},\"supportsTablet\":true},\"name\":\"Bluesky\",\"orientation\":\"portrait\",\"owner\":\"blueskysocial\",\"platforms\":[\"android\",\"ios\",\"web\"],\"plugins\":[\"./plugins/shareExtension/withShareExtensions.js\",\"./plugins/withAndroidManifestFCMIconPlugin.js\",\"./plugins/withAndroidManifestPlugin.js\",\"./plugins/withAndroidSplashScreenStatusBarTranslucentPlugin.js\",\"./plugins/withAndroidStylesWindowBackgroundPlugin.js\",\"expo-localization\",[\"expo-build-properties\",{\"android\":{\"buildToolsVersion\":\"34.0.0\",\"compileSdkVersion\":34,\"kotlinVersion\":\"1.8.0\",\"newArchEnabled\":false,\"targetSdkVersion\":34},\"ios\":{\"deploymentTarget\":\"13.4\",\"newArchEnabled\":false}}],[\"expo-notifications\",{\"color\":\"#1185fe\",\"icon\":\"./assets/icon-android-notification.png\"}],[\"expo-updates\",{\"username\":\"blueskysocial\"}]],\"scheme\":\"bluesky\",\"sdkVersion\":\"50.0.0\",\"slug\":\"bluesky\",\"splash\":{\"backgroundColor\":\"#ffffff\",\"image\":\"./assets/splash.png\",\"resizeMode\":\"cover\"},\"updates\":{\"enabled\":true,\"fallbackToCacheTimeout\":1000,\"url\":\"https://u.expo.dev/55bd077a-d905-4184-9c7f-94789ba0f302\"},\"userInterfaceStyle\":\"automatic\",\"version\":\"1.75.0\",\"web\":{\"favicon\":\"./assets/favicon.png\"}}",
    "reasons": [
      "expoConfig"
    ],
    "hash": "8059d39e6c4ce29ff240a75a28ae38abf53877a5"
  }
]

Generated by PR labeler 🤖

Copy link

github-actions bot commented Apr 5, 2024

Old size New size Diff
8.01 MB 8.01 MB 25 B (0.00%)

@haileyok
Copy link
Contributor

haileyok commented Apr 5, 2024

Those lint errors are fixed in #3369, so no need to fix separately here. Just merge in at your leisure 🥳

@mozzius mozzius marked this pull request as ready for review April 10, 2024 14:01
@mozzius mozzius changed the title iPad support [WIP] iPad support Apr 10, 2024
Copy link

render bot commented Jun 10, 2024

@kandros
Copy link

kandros commented Nov 8, 2024

Hey @pfrazee, I’m interested in adding iPad support, do you thing the problem faced prev year have been addressed already eg design system? Should we move this PR forward of create a new one?

@O4FDev
Copy link
Contributor

O4FDev commented Nov 24, 2024

As everyone can see there's a lot of community feeling around this PR lol.

Any outstanding issues that could do with a hand? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants