Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move invite-state to new persistence + context and replace the invite-use notifications #1840

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Nov 8, 2023

Moves local invite-state to a context/hook and the new persistence layer. Also replaces the janky fake notification of an invite usage with just showing who used the invites in the modal:

CleanShot 2023-11-07 at 17 30 24@2x

I swapped that out to simplify this PR and because that fake notification caused way more trouble than it was worth

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Genius, visionary

@pfrazee pfrazee force-pushed the invited-users-persistence-update branch from 92b7378 to 93f4346 Compare November 8, 2023 17:10
@pfrazee pfrazee merged commit e75b2d5 into main Nov 8, 2023
3 of 4 checks passed
@pfrazee pfrazee deleted the invited-users-persistence-update branch November 8, 2023 17:11
estrattonbailey added a commit that referenced this pull request Nov 8, 2023
…-state-into-separate-statecontext

* origin:
  Move invite-state to new persistence + context and replace the notifications with just showing uses in the modal (#1840)
  Move muted threads to new persistence + context (#1838)
  Move onboarding state to new persistence + reducer context (#1835)
  Move require alt-text to new persistence + context (#1839)
  Move reminders to new persisted state layer (#1834)
  Add persistent state provider (#1830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants