Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync top/bottom bar disappearance to the scroll #1855

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Sync top/bottom bar disappearance to the scroll #1855

merged 8 commits into from
Nov 9, 2023

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 9, 2023

OK, I've wanted to do this since forever.

The most natural way for the "minimal shell" showing and hiding to work is to stay exactly in sync with the scroll gesture. It shouldn't "fly away" independently from what your finger is doing. This avoids showing weird blank spaces.

This might need a bit of testing. Happy to take feedback on the code/naming, not sure if it's a bit messy. Note the screen captures are missing the "is scrolled down" logic for the left floating button but I fixed it after recording.

iOS

ios.mov

Android

android.mov

Web

web.mov

@gaearon gaearon changed the title Sync top/bottom bar disappearance to the scrolling gesture Sync top/bottom bar disappearance to the scroll Nov 9, 2023
@gaearon gaearon requested a review from pfrazee November 9, 2023 18:44
ansh
ansh approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@ansh ansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

pfrazee
pfrazee approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is beautiful, love it

@pfrazee pfrazee merged commit 7a55ca6 into main Nov 9, 2023
4 checks passed
@pfrazee pfrazee deleted the minimal-shell-gesture branch November 9, 2023 20:15
@gaearon gaearon mentioned this pull request Nov 9, 2023
Merged
estrattonbailey added a commit that referenced this pull request Nov 9, 2023
@estrattonbailey
Merge remote-tracking branch 'origin' into eric/session-hook
3ef683e 
* origin:
  Fix tab alignment on the web (#1857)
  Show tabs when swiping feeds (#1856)
  Sync top/bottom bar disappearance to the scroll (#1855)
  Hotfix internationalization on mobile (#1854)
  Internationalization & localization (#1822)
  Hide/show header and footer without re-renders, take two (#1849)
@gaearon gaearon mentioned this pull request Nov 13, 2023
Open
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh ansh ansh approved these changes

@pfrazee pfrazee pfrazee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @pfrazee @ansh