Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hindi Internationalization #1914

Merged
merged 15 commits into from
Nov 20, 2023
Merged

Hindi Internationalization #1914

merged 15 commits into from
Nov 20, 2023

Conversation

ansh
Copy link
Contributor

@ansh ansh commented Nov 15, 2023

This PR aims to fully internationalize the Bluesky website and app in Hindi to set precedence for internationalization to other languages.

It completes the /locale/locales/hi/messages.po file and uses that to create a /locale/locales/hi/messages.js which allows the lingui package to fill in different language strings wherever necessary.

There may be a few strings missing, but this PR has been tested on web, mobile, and Android.

To change your language, go to Settings:
CleanShot 2023-11-15 at 14 46 57@2x
Then go to Languages:
CleanShot 2023-11-15 at 14 47 07@2x
Then select your desired language:
CleanShot 2023-11-15 at 14 47 21@2x

This is instantly update all the strings throughout the app.

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +30 to +31
<Trans>
<Text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa it works like this too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir!

@ansh ansh merged commit c5b6f88 into main Nov 20, 2023
4 checks passed
@ansh ansh deleted the internationalization-hindi branch November 20, 2023 21:29
estrattonbailey added a commit that referenced this pull request Nov 21, 2023
* origin:
  Hindi Internationalization (#1914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants