Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make like colour consistent across the app #2234

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Dec 18, 2023

There are some instances where colors.red3 is used instead of colors.like, which results in a much-complained-about difference between the heart icon and the text next to it when a post is liked.

This PR uses s.likeColor everywhere, increasing consistency.

Fixes #2223

@pfrazee
Copy link
Collaborator

pfrazee commented Dec 18, 2023

CleanShot 2023-12-18 at 09 45 43@2x

That's weird. I know github says the code changed but both lines look exactly the same to me

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mozz :)

@pfrazee pfrazee merged commit edc6bdb into bluesky-social:main Dec 18, 2023
4 checks passed
@mozzius mozzius deleted the consistant-like-colour branch December 18, 2023 18:44
estrattonbailey added a commit that referenced this pull request Dec 18, 2023
* origin/main: (22 commits)
  basic public RSS feed for profiles (#2229)
  use `s.likeColor` everywhere (#2234)
  Add credits to localization doc (#2233)
  Fix `Logotype` fill for dark mode (#2230)
  Hide label appeal on self-labeled posts (#2232)
  Fix & Add: Japanese Translation (3) (#2226)
  tweak social card meta yet again (#2228)
  bskyweb: update golang indigo dep (from May!), and some small devex tweaks (#2227)
  Fix: Some display issues (#2219)
  Update splash screen tagline, update translations, bump ios build number
  Bump ios build number
  Tweaks (#2225)
  1.60
  Traffic reduction and tuned caching strats (#2215)
  Super secret changes don't look (#2218)
  Fix android icon dims (#2213)
  Log post creation failures (#2205)
  Some brand, some pwi (#2212)
  🤫  (#2211)
  PWI behavior updates (#2207)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color for # of likes and heart icon are not the same
2 participants