Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the user from posting before the link card finishes loading #2328

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Dec 27, 2023

There have been a lot of attempts to share youtube videos where no metadata is extracted into the link card. The only way I was able to reproduce that was by not waiting for the link card to finish fetching.

This isn't an ideal way to solve that, but it does solve it: it stops the user from posting while it's loading.

CleanShot 2023-12-26 at 19 25 28@2x

Closes #2328

@pfrazee
Copy link
Collaborator Author

pfrazee commented Dec 27, 2023

Confirmed by discussing with users this is the cause.

@pfrazee pfrazee merged commit 3b240db into main Dec 27, 2023
4 checks passed
@pfrazee pfrazee deleted the 2318-yt-metadata branch December 27, 2023 16:47
ansh added a commit that referenced this pull request Jan 3, 2024
* Create messages.

* Update helpers.test.ts

* Update helpers.ts

* Update i18n.ts

* Update i18n.web.ts

* Update languages.ts

* Update i18n.ts

* Update lingui.config.js

* Correct file name and remove unused variables!

* Update Language-Team

* Update Bump ios build

* Fix for Stop the user from posting before the link card finishes loading #2328

* Update based in model en

* Update last version lang

* Update messages.po tsx:160 and tsx:143

* Bump ios build number and android version code

* adjustment

* adjustment 100%

* Update Date

* Update Day for Merge

* Update Name Maison for Maison da Silva

* fix order of case

* fix lint

* add tag for BR portugese

* add tag for BR

* update `pt` to `pt-BR`

---------

Co-authored-by: Maison da Silva <maisonmdsgreen@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants