Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New user home feed fixes #2421

Merged
merged 3 commits into from
Jan 5, 2024
Merged

New user home feed fixes #2421

merged 3 commits into from
Jan 5, 2024

Conversation

pfrazee
Copy link
Collaborator

@pfrazee pfrazee commented Jan 4, 2024

  • 7bd9d9e Restores discover to default feeds for new users (should not have been removed)
  • 1cb9aba Updates the mergefeed emergency fallback to only source from discover
  • 736aeca Makes sure the mergefeed always returns a cursor, which protects against a case where the emergency mergefeed might give the "end of feed" condition prematurely. That has the potential to create an endless spinner if the mergefeed is actually out of posts, but that's very unlikely with multiple custom feeds, while the more likely issue is that the emergency mergefeed will glitch out.

All of this is a temporary solution to ensuring that new users get content after signup. We will replace all of this in the near future.

@pfrazee pfrazee merged commit 8a4a8af into main Jan 5, 2024
4 checks passed
@pfrazee pfrazee deleted the onboard-feed-fixes branch January 5, 2024 01:34
pull bot pushed a commit to imax9000/bsky-app-ua that referenced this pull request Jan 6, 2024
@pfrazee @pull
New user home feed fixes (bluesky-social#2421)
31b2576 
* Readd discover to default feeds for new users

* Fallback just to discover in home when mergefeed is disabled

* Always provide a cursor with mergefeed (no 'end of feed' condition)
estrattonbailey added a commit that referenced this pull request Jan 8, 2024
@estrattonbailey
Merge remote-tracking branch 'origin' into eric/nova
4a52825 
* origin: (45 commits)
  Fix splash config (#2452)
  convert prefix to lowercase in actor autocomplete query (#2431)
  support intl tenor links (#2438)
  Splash: reduce motion + dark mode (#2448)
  Bump android app version code
  Don't use mask for android at all (#2445)
  Update Korean localization (#2432)
  Use android mode, fix fallback (#2437)
  Update for Version 1.63 Português (BR) (#2435)
  New translations messages.po (Ukrainian) (#2422)
  Update Japanese localization (addition + language code correction) (#2423)
  1.63
  Additional embed sources and external-media consent controls (#2424)
  Reduce web requests (#2420)
  New user home feed fixes (#2421)
  E2E runner fixes (#2428)
  Recompile all locales (#2411) (#2416)
  Add Ukrainian localization (#2336)
  Update Portuguese for Português (#2414)
  Add Portuguese Localization (#2407)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pfrazee