Suggest post language correction #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #2387 |
estrattonbailey
approved these changes
Jan 11, 2024
estrattonbailey
added a commit
that referenced
this pull request
Jan 18, 2024
* origin/main: (44 commits) Patch `@lingui/core` to fix `unraw` import resolution error (#2548) 1.65 Fix the fallback to discover behavior on the home feed (#2546) Bump android version code Bump ios build number Add a new home feed-api wrapper and give a header indicating the fallback behavior (#2534) Add accept-language header (#2457) rss: filter out replies server-side (#2518) feat: show muted/blocked status on list card (#2523) 1.64 (#2521) Bump react-native@0.73.2 (#2519) Create a profile record on new user (#2520) fix: truncate long email address (#2493) fix: set html lang according to app language (#2496) Ensure sessions and tokens are synced between tabs (#2498) package.json: cp --verbose doesn't exist on macos (#2501) Suggest post language correction (#2486) (optional) In app browser (#2490) Toggle minimal shell on any scroll for web (#2499) ✨ New report type, appeal (#2455) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #2484
Final Screenshot:
Copying over original description:
Fixes #2449
code3ToCode2Strictmapping function because it seems thatlandereturns language codes that we don't have in our mapping, we should just filter those out. (Mixed English+Japanese seems to be returningcmnand I can't figure out what language is)landeis going to return incorrect matches for them anywaylandeis being run in arequestIdleCallback, not sure if this is the right call, perhaps a timeout would be a better idea instead?