Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean localization #2494

Merged
merged 18 commits into from
Jan 22, 2024

Conversation

quiple
Copy link
Contributor

@quiple quiple commented Jan 11, 2024

I've localized the added strings. It would be great to merge it when the next release comes out!

I'll keep updating this PR as additional strings become available.

@pfrazee pfrazee added the intl Internationalization label Jan 12, 2024
@quiple
Copy link
Contributor Author

quiple commented Jan 13, 2024

I updated for the added strings.

@hurss
Copy link

hurss commented Jan 14, 2024

I have update a little translation text from https://github.com/quiple/social-app/tree/update-korean-localization. My repository is https://github.com/hurss/social-app/tree/korean-localization if you want to update Korean translation.

@quiple
Copy link
Contributor Author

quiple commented Jan 15, 2024

I have update a little translation text from https://github.com/quiple/social-app/tree/update-korean-localization. My repository is https://github.com/hurss/social-app/tree/korean-localization if you want to update Korean translation.

Thank you! I double-checked the string in that part against your localizations and updated the localizations.

@quiple
Copy link
Contributor Author

quiple commented Jan 18, 2024

I would like #2537 to be merged first before merging this.

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 19, 2024

@quiple okay that's merged. I assume you want to tune something here in response, then this is ready to go?

@pfrazee pfrazee self-assigned this Jan 19, 2024
@quiple
Copy link
Contributor Author

quiple commented Jan 19, 2024

@quiple okay that's merged. I assume you want to tune something here in response, then this is ready to go?

@pfrazee I found one more part of the translation where the position of Trans needed to be changed. #2568

I've updated the Korean localization. Please merge the above PR and I'll update again.

@quiple
Copy link
Contributor Author

quiple commented Jan 20, 2024

@pfrazee I don't think there's any problem with merging it now, thanks!

@quiple
Copy link
Contributor Author

quiple commented Jan 21, 2024

@pfrazee Please merge #2502 as well, and I'll update localization again.

@pfrazee
Copy link
Collaborator

pfrazee commented Jan 22, 2024

@quiple okay done -- lmk when this is good to go

@quiple
Copy link
Contributor Author

quiple commented Jan 22, 2024

@pfrazee Yeap, I think It's done, thanks!

Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you! Merging!

@pfrazee pfrazee merged commit 1828bc9 into bluesky-social:main Jan 22, 2024
4 checks passed
estrattonbailey added a commit that referenced this pull request Jan 23, 2024
* origin: (109 commits)
  Update Korean localization (#2494)
  fix: don't expose post content on no-unauthenticated (#2584)
  Tweak positioning
  use color scheme in in-app browser (#2580)
  Fix jump when opening last post in thread (#2591)
  Fix orphan replies in linear mode (#2578)
  Fix typos, improve localization and unify separators (#2502)
  Update Japanese localization based on the latest codebase (#2509)
  Update pt-BR translation (#2471)
  New Web Layout (#2126)
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  Update src/locale/locales/id/messages.po
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intl Internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants