Fix collisions in UITextView for onPress events #3017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we find the pressed string's indices in the
NSAttributedString
withfullText.range(of: childText)
. However, we are not taking into account situations where there may be duplicate strings as in the screenshot below. Each of these has a differentonPress
handler, and the press location will not be the same. However, we are not offsetting the search as we loop through each child.Instead, we need to save the last offset and apply that to the search, like so:
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-28.at.08.28.52.mp4