Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nested border radius issue on square avatars #3230

Closed
wants to merge 229 commits into from
Closed

Fix nested border radius issue on square avatars #3230

wants to merge 229 commits into from

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Mar 17, 2024

Before:

image

image

After:

image

image

The rounding of the default avatar was baked into the SVG, so I had to replace the path with a rect.

pfrazee and others added 30 commits February 7, 2024 11:56
@pfrazee
Add modservice screen and profile-header-card
8182047
@pfrazee
Drop the guidelines for now
c0771de
@pfrazee
Remove ununsed constants
981fc67
@pfrazee
Add label & label group descriptions
dd56bee
@estrattonbailey
Not found state
5998b34
@estrattonbailey
Reorg, add icon
af5b545
@estrattonbailey
Subheader
8e1575f
@estrattonbailey
Header
9a57155
@estrattonbailey
Complete header
97bfa40
@estrattonbailey
Clean up
e006105
@estrattonbailey
Add all groups
fabf680
@estrattonbailey
Fix scroll view
f4ce9e2
@estrattonbailey
Dialogs side quest
5bd64fb
@estrattonbailey
Remove log
270476a
@pfrazee
Add (WIP) debug mod page
15d0f2e
@estrattonbailey
Dialog solution
4edbcd2
@estrattonbailey
Add note
fe20b4d
@pfrazee
Clean up and reorganize localized moderation strings
667729f
@estrattonbailey
Memoize
97572fd
@estrattonbailey
Add example
b6552e9
@estrattonbailey
Add first ReportDialog screen
f71cccd
@estrattonbailey
Report dialog step 2
e45cc6f
@estrattonbailey
Submit
9b5f80b
@estrattonbailey
Integrate updates
937b66e
@estrattonbailey
Merge remote-tracking branch 'origin/main' into 3p-moderators
9075c50 
* origin/main: (33 commits)
  Improved server selector during account creation and signin (#2840)
  remove line height from text input for composer on ios (#2844)
  Add follow button to highlighted post (#2828)
  Cleaning up old codes pt_BR (#2809)
  Fix wrong translations in zh-CN localization  (#2812)
  Adjust Japanese translation (#2814)
  Update ja messages.po (#2821)
  change follow to follow all when !== 20 (#2831)
  ios adult content link fix 🤦 (#2845)
  improves build.md completeness (#2835)
  increase stroke width for active hashtag icon (#2829)
  Update `blueskyweb.xyz` links to `bsky.social` (#2830)
  eas nightlies (#2826)
  Always show post dropdown button at the bottom of the post, add share button to highlighted post (#2646)
  Measure header layout reliably (#2817)
  Round line height (#2824)
  Design system tweaks (#2822)
  Fix layout calculations (#2816)
  Fix flashes and jumps when opening profile (#2815)
  Show text cursor on web bio (#2813)
  ...
@estrattonbailey
Move moderation screen
a289b61
@estrattonbailey
Migrate buttons
6558245
@estrattonbailey
Migrate everything
53da8d7
@estrattonbailey
Rough sketch
95707a1
@pfrazee
Fix types
4e9eed5
pfrazee and others added 27 commits March 13, 2024 21:42
@pfrazee
revert dipendencies
646c318
@pfrazee
Add some explainers on how blocking affects labelers
a94f99a
@pfrazee
Tweak copy
b8162aa
@estrattonbailey
Fix underline color in header
84f4c42
@estrattonbailey
Fix profile menu
2b0db1f
@estrattonbailey
Handle card overflow
dbb34eb
@estrattonbailey
Remove metrics from header
b6993d9
@estrattonbailey
Mute 'account' not 'user'
67edca4
@estrattonbailey
Show metrics if self
4e525cd
@pfrazee
Show the labels tab on logged out view
35c4eac
@estrattonbailey
Merge remote-tracking branch 'origin/main' into 3p-moderators
429a5ab 
* origin/main:
  add warning to profile as well
  use prompt.basic instead of full prompt
  [Statsig] Track posting, end reached (#3206)
  [Statsig] Track likes, reposts, follows (#3195)
  1.73 Version Bump (#3200)
@estrattonbailey
Fix bad merge
cc47256
@pfrazee
Use purple theming on labelers
fc7eb58
@pfrazee
Merge branch '3p-moderators' of github.com:bluesky-social/social-app …
d410aee 
…into 3p-moderators
@estrattonbailey
Tighten space on LabelerCard
c5d5261
@estrattonbailey
Set staleTime to 6hrs for labeler details
7f178ff
@estrattonbailey
Memoize the memoizers
6a7f904
@estrattonbailey
Drop staleTime to 60s
8e12918
@pfrazee
Move label defs into a context to reduce recomputes
7c675b4
@estrattonbailey
Submit view tweaks
3e12132
@estrattonbailey
Move labeler fetch below auth
b4bb838
@pfrazee
Mitigation: hardcode the bluesky moderation labeler name
56acbb2
@estrattonbailey
Bump sdk
9d1f3c3
@estrattonbailey @tkusano
Add missing translated string
330eaf3 
Co-authored-by: Takayuki KUSANO <65759+tkusano@users.noreply.github.com>
@estrattonbailey @tkusano
Add missing translated string
98c2a6a 
Co-authored-by: Takayuki KUSANO <65759+tkusano@users.noreply.github.com>
@mozzius
change outer border radius to 10
8725660
@mozzius
change default avi to use a rect instead of a path
c765531
Base automatically changed from 3p-moderators to main March 18, 2024 19:46
@mozzius mozzius closed this Mar 18, 2024
@mozzius mozzius mentioned this pull request Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mozzius @pfrazee @estrattonbailey