Enforce Text suffix for Text-rendering components #3407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3398.
This renames a bunch of components that always "promise" to render Text:
Description
->DescriptionText
InlineLink
->InlineLinkText
Label
->LabelText
Suffix
->SuffixText
It's not super "pretty" but it very clearly communicates the expectations that they render Text.
I've left H1..H7 and P "as is" because they're obviously text.
The last commit adds a lint rule check that enforces that such components always return
Text
.That's to prevent regressions.
This doesn't address buttons which I'll need to take a pass on separately.
Test Plan
Did this via IDE renames (TS language server). Walked around the app too.