Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Japanese translation #3425

Merged
merged 9 commits into from
Apr 13, 2024
Merged

Conversation

tkusano
Copy link
Contributor

@tkusano tkusano commented Apr 5, 2024

  • Translated new messages
  • Changed some symbols and numbers from half-width to full-width
  • Removed obsoleted messages

@tkusano
Copy link
Contributor Author

tkusano commented Apr 5, 2024

TODO:
「誕生日」or「生年月日」?

@tkusano tkusano marked this pull request as draft April 5, 2024 14:45
@tkusano tkusano marked this pull request as ready for review April 5, 2024 17:07
@tkusano
Copy link
Contributor Author

tkusano commented Apr 7, 2024

@Hima-Zinn @dolciss @oboenikui @noritada @middlingphys @hibiki @reindex-ot @haoyayoi @vyv03354
レビューしていただけると助かります
It would be helpful if you could review it.

Copy link
Contributor

@Hima-Zinn Hima-Zinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the unused sections. I need to get confirmation from some people, but I don't see any problem.

@hibiki
Copy link
Contributor

hibiki commented Apr 7, 2024

TODO: 「誕生日」or「生年月日」?

生年月日のほうが、「年」も入れるのだなと分かりやすいように感じますが、どうでしょうか?

@vyv03354
Copy link

vyv03354 commented Apr 7, 2024

英語版との比較を容易にするために、#~でコメントアウトされていても英語版に残っているものはそのまま残したほうがいいと思います。余計な差分を減らすために#~ msgstr ""に戻す(コメントアウトされた訳語のみ削除する)のはいいかもしれません。

@vyv03354
Copy link

vyv03354 commented Apr 7, 2024

あるいは英語版に対してコメントアウトの削除や欠落しているmsgid追加のPRを出して、こちらのPRはそのPRに対する差分にするか

@tkusano
Copy link
Contributor Author

tkusano commented Apr 8, 2024

TODO: 「誕生日」or「生年月日」?

生年月日のほうが、「年」も入れるのだなと分かりやすいように感じますが、どうでしょうか?

The translation of "birthdate", "birth date", "birthday" as "誕生日" may not include the year, so it is better to use "生年月日".

"birthdate", "birth date", "birthday"の訳語が「誕生日」だと年が含まれないことがあるので「生年月日」のほうがよさそうですね

@tkusano
Copy link
Contributor Author

tkusano commented Apr 8, 2024

英語版との比較を容易にするために、#~でコメントアウトされていても英語版に残っているものはそのまま残したほうがいいと思います。余計な差分を減らすために#~ msgstr ""に戻す(コメントアウトされた訳語のみ削除する)のはいいかもしれません。

不要なエントリを削除せず、戻してみました

@tkusano
Copy link
Contributor Author

tkusano commented Apr 10, 2024

Translated 2 new messages (+ 1 follow capitalization change)

2つのメッセージを新規に翻訳しました(+原文の大文字・小文字変更への追従1つ)

@tkusano
Copy link
Contributor Author

tkusano commented Apr 11, 2024

Followed changes in the search results screen in main, almost unified the translation of 'people' to 'ユーザー'
image

@pfrazee
Copy link
Collaborator

pfrazee commented Apr 12, 2024

Thank you so much everyone! Is this ready to go?

@Hima-Zinn
Copy link
Contributor

@tkusano

@tkusano
Copy link
Contributor Author

tkusano commented Apr 13, 2024

@pfrazee
okay, ready to merge.

@pfrazee
Copy link
Collaborator

pfrazee commented Apr 13, 2024

Awesome! Thanks all!

@pfrazee pfrazee merged commit a8c1e71 into bluesky-social:main Apr 13, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request Apr 14, 2024
…file

* origin/main: (222 commits)
  Release 1.77.0 (#3549)
  Improve the language behaviors around the PWI (#3545)
  fix: only close drawer if directly tapping backdrop (#3534)
  Fix Android in-app browser closing when switching apps (#3546)
  Cache DID and profile basic on profile card presses (#3523)
  Remove extra wrapper on notification user links (#3548)
  Fix hover card animation with a reducer (#3547)
  Update Ukrainian translation (#3537)
  add oEmbed links to public post HTML meta headers (#3522)
  rebased embedr (#3511)
  Increase hit slop for web's app language picker (#3535)
  Update Japanese translation (#3425)
  Fix oopsie (#3538)
  Fade in animation for card (#3521)
  [Embeds] Add ref_url (#3533)
  add ref_src (#3532)
  [Embed] Don't reuse DOM when changing embed (#3530)
  [Statsig] Send ref source (#3531)
  More obvious click area (#3528)
  add hideRecord prop (#3527)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants