Profile card hover preview #3508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/main: (455 commits) Use getSuggestions endpoint behind the gate (#3499) Added `new_profile_scroll_component` to `Gate` type (#3487) Fix useGate lint rule (#3486) Make bio area scrollable on iOS (#2931) Improve Android haptic, offer toggle for haptics in the app (#3482) Search - only enable queries once tab is active (#3471) [Statsig] Mark Testflight as staging tier (#3470) [Statsig] Typecheck gates (#3467) Bump to 1.77 (#3468) Search - extra tabs (#3408) notify slack on production builds (#3461) notify slack on production builds (#3460) 1.76 release preparations (#3459) Update zh-CN translation (#3433) Italian Localization (#3388) [Statsig] Send prev route name (#3456) [Statsig] Instrument feed display (#3455) Small logic cleanups (#3449) Use ALF for the embed consent modal (#3336) Onboarding tweaks (#3447) ...
* origin/main: Fix stale Notifications after push (#3507) Fix: dont let notifications count go behind the icon (#3505) QT Jump Pt. 2 - Remove code duplication (#3506) Fix optimistic like/repost (#3503) remove build-embed from Dockerfile (#3502) Dont apply the content-language filter if it will remove all content (#3492) [Embeds] Create vite project and add to build pipeline (#3448) add `likeCount` etal. to `embedViewRecordToPostView` (#3500)
|
The Pull Request introduced fingerprint changes against the base commit: f91aa37 Fingerprint diff[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"deda9db58671251a611b4fe44df27971e7310c27"}]Generated by PR labeler 🤖 |
|
* origin/main: Store QP authors in the DID cache (#3509)
haileyok
force-pushed
the
feat/web-profile-hover
branch
from
6336c5d to
48beab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2867
Key things:
RichTextas wellLinkfrom the hover card itself, see usagesRe: closing on click of a link, I didn't think it was a good experience to close on any click inside e.g. the Follow button. Seemed to make sense to handle individually.
Also I chose not to enable hashtags in profiles, but we potentially could.