Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search in PWI #3628

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Search in PWI #3628

merged 1 commit into from
Apr 19, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 19, 2024

I kept the special empty state for PWI (since we have no suggested follows), the rest moved out of the hasSession codepath.

search1.mov
search2.mov

Test Plan

Tried search both logged in and logged out. Switched between tabs.

Also verified directly landing on /search works and shows a good empty state.

Copy link

render bot commented Apr 19, 2024

Copy link

Old size New size Diff
6.44 MB 6.44 MB -457 B (-0.01%)

Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, still respects opt-outs as well and everything.

One thing we might want to do for later (not sure how we feel about it though) is make it more obvious where the search page is on native. I wouldn't really think to look in the drawer tbh.

@gaearon gaearon merged commit ce1c1e1 into main Apr 19, 2024
6 checks passed
@gaearon gaearon deleted the search-pwi branch April 19, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants