Remove Moderation from the sidebar #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-3692.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cokmkq21hbls73c5061g. |
gaearon
commented
Apr 24, 2024
| @@ -494,107 +494,107 @@ export function SettingsScreen({}: Props) { | |||
| </Text> | |||
| </TouchableOpacity> | |||
| <TouchableOpacity | |||
| testID="preferencesHomeFeedButton" | |||
| testID="languageSettingsBtn" | |||
There was a problem hiding this comment.
Changes in this file are just reorders.
Proposed new order:
|
pfrazee
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty busy in the left pane. Adjusting moderation settings isn't something you do every day, and it makes sense for them to just live in Settings. Let's remove the shortcut from the left pane. So you'd have to go Settings > Moderation. In Settings, I moved Moderation up so that it goes after Accessibility and Languages. So it's still easy to find.
Left nav, desktop
Drawer, mobile web
Drawer, iOS
Drawer, Android
(Finally, I don't need to scroll to get to Settings.)
Settings
I reordered some stuff so these go first: