Remove useEffect from TimeElapsed #3741
Conversation
|
Your Render PR Server URL is https://social-app-pr-3741.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-con7vcmv3ddc7392kbtg. |
| @@ -3,8 +3,6 @@ import React from 'react' | |||
| import {useTickEveryMinute} from '#/state/shell' | |||
| import {ago} from 'lib/strings/time' | |||
|
|
|||
| // FIXME(dan): Figure out why the false positives | |||
There was a problem hiding this comment.
This is something unrelated about lint and types that's since been addressed.
|
| React.useEffect(() => { | ||
| const [prevTick, setPrevTick] = React.useState(tick) | ||
| if (prevTick !== tick) { | ||
| setPrevTick(tick) |
There was a problem hiding this comment.
Isn't that (bad setState in render)?
I mean this error:
Warning: Cannot update a component (
App) while rendering a different component (Watever). To locate the bad setState() call insideWatever, follow the stack trace as described in https://reactjs.org/link/setstate-in-render
There was a problem hiding this comment.
That error is about updating a different component. Updating the same component is ok if it's following this specific pattern: https://react.dev/reference/react/useState#storing-information-from-previous-renders
It's not needed and forces an unnecessary second render pass.
See https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes.
Test Plan
Waited a minute, verified timestamps get updated.