-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Session] Refactor to prepare for V2 #3781
Conversation
Co-authored-by: dan <dan.abramov@gmail.com>
Your Render PR Server URL is https://social-app-pr-3781.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-coopb3u3e1ms73bpr0sg. |
|
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
This ensures that the app labelers get reset in a test environment. Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes on web/ios, minus the last commit, but that looks good to me too. Idk if you're ready for a stamp but here's one if it helps unblock! Happy to look again later.
This is a series of (supposedly safe) refactors extracted from #3728 and moving us closer to its final state. They are intended to be safe and are not intended to change any functionality except one test-only case (c57da3a).
Test Plan
Read individual commits. The usual login/logout/switch pass. I'll be doing more thorough testing when I finish the stack.