Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session] Refactor to prepare for V2 #3781

Merged
merged 11 commits into from
May 1, 2024
Merged

[Session] Refactor to prepare for V2 #3781

merged 11 commits into from
May 1, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented May 1, 2024

This is a series of (supposedly safe) refactors extracted from #3728 and moving us closer to its final state. They are intended to be safe and are not intended to change any functionality except one test-only case (c57da3a).

Test Plan

Read individual commits. The usual login/logout/switch pass. I'll be doing more thorough testing when I finish the stack.

Co-authored-by: dan <dan.abramov@gmail.com>
Copy link

render bot commented May 1, 2024

Copy link

github-actions bot commented May 1, 2024

Old size New size Diff
6.49 MB 6.49 MB 573 B (0.01%)

estrattonbailey and others added 4 commits May 1, 2024 02:12
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
This ensures that the app labelers get reset in a test environment.

Co-authored-by: dan <dan.abramov@gmail.com>
gaearon and others added 5 commits May 1, 2024 02:21
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes on web/ios, minus the last commit, but that looks good to me too. Idk if you're ready for a stamp but here's one if it helps unblock! Happy to look again later.

@gaearon gaearon merged commit 39807a8 into main May 1, 2024
6 checks passed
@gaearon gaearon deleted the session-pt-2 branch May 1, 2024 01:55
@gaearon gaearon mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants