Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session] Derive currentAccount from accounts + currentAccountDid #3795

Merged
merged 2 commits into from
May 1, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented May 1, 2024

We should be able to reconstruct currentAccount on demand from accounts and only track the current DID instead. Although we've wanted to make a bigger change to this in #3728 (and reconstruct it from agent), I'm doing a more incremental step here.

Test Plan

Careful reading. Verify login/logout/switch still works. Do it in another tab too.

Copy link

render bot commented May 1, 2024

Copy link

github-actions bot commented May 1, 2024

Old size New size Diff
6.49 MB 6.49 MB 0 B (0.00%)

Copy link
Member

@estrattonbailey estrattonbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaearon gaearon merged commit d61b366 into main May 1, 2024
6 checks passed
@gaearon gaearon deleted the session-pt-4 branch May 1, 2024 16:35
@gaearon gaearon mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants